[Qemu-devel] please review smc91c111 network bug fix

[Qemu-devel] please review smc91c111 network bug fix

[Wang Cheng Yeh]

[-- Attachment #1.1: Type: text/plain, Size: 56 bytes --]

address mapping error and cause arm versatile unstable.

[-- Attachment #1.2: Type: text/html, Size: 76 bytes --]

[-- Attachment #2: pat.txt --]
[-- Type: text/plain, Size: 855 bytes --]

Index: hw/smc91c111.c
===================================================================
RCS file: /sources/qemu/qemu/hw/smc91c111.c,v
retrieving revision 1.5
diff -u -r1.5 smc91c111.c
--- hw/smc91c111.c	21 Dec 2006 17:23:49 -0000	1.5
+++ hw/smc91c111.c	24 Mar 2007 18:15:21 -0000
@@ -446,7 +446,9 @@
         case 7:
             /* Not implemented.  */
             return 0;
-        case 8: /* Free memory available.  */
+        case 8: /* Memory size.  */
+            return NUM_PACKETS;
+        case 9: /* Free memory available.  */
             {
                 int i;
                 int n;
@@ -457,8 +459,6 @@
                 }
                 return n;
             }
-        case 9: /* Memory size.  */
-            return NUM_PACKETS;
         case 10: case 11: /* RPCR */
             /* Not implemented.  */
             return 0;

Re: [Qemu-devel] please review smc91c111 network bug fix

[Aurelien Jarno]

Wang Cheng Yeh a écrit :
> address mapping error and cause arm versatile unstable.
> 

This patches looks ok to me, at least it corresponds to what the
datasheet says. I am using it for a few hours, I have seen no regression
so far.

> 
> Index: hw/smc91c111.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/smc91c111.c,v
> retrieving revision 1.5
> diff -u -r1.5 smc91c111.c
> --- hw/smc91c111.c	21 Dec 2006 17:23:49 -0000	1.5
> +++ hw/smc91c111.c	24 Mar 2007 18:15:21 -0000
> @@ -446,7 +446,9 @@
>          case 7:
>              /* Not implemented.  */
>              return 0;
> -        case 8: /* Free memory available.  */
> +        case 8: /* Memory size.  */
> +            return NUM_PACKETS;
> +        case 9: /* Free memory available.  */
>              {
>                  int i;
>                  int n;
> @@ -457,8 +459,6 @@
>                  }
>                  return n;
>              }
> -        case 9: /* Memory size.  */
> -            return NUM_PACKETS;
>          case 10: case 11: /* RPCR */
>              /* Not implemented.  */
>              return 0;
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net