From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hfc7l-0000N7-Ue for qemu-devel@nongnu.org; Sun, 22 Apr 2007 09:29:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hfc7g-0000MA-8h for qemu-devel@nongnu.org; Sun, 22 Apr 2007 09:29:05 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hfc7g-0000M4-2u for qemu-devel@nongnu.org; Sun, 22 Apr 2007 09:29:00 -0400 Received: from wx-out-0506.google.com ([66.249.82.238]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hfc2A-0006O4-PK for qemu-devel@nongnu.org; Sun, 22 Apr 2007 09:23:30 -0400 Received: by wx-out-0506.google.com with SMTP id i30so2483121wxd for ; Sun, 22 Apr 2007 06:22:47 -0700 (PDT) Message-ID: Date: Sun, 22 Apr 2007 21:22:43 +0800 From: "Wang Cheng Yeh" In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_130823_30825521.1177248163464" References: <41e41e7a0704220254p3da2ff36v1203fc2666ef65a@mail.gmail.com> Subject: [Qemu-devel] scsi interface patch Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_130823_30825521.1177248163464 Content-Type: multipart/alternative; boundary="----=_Part_130824_4110799.1177248163464" ------=_Part_130824_4110799.1177248163464 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline I am sorry. The new attached file is created by (cvs diff -up). 2007/4/22, Hetz Ben Hamo : > > The "standard" way to submitting patches is unified diff's (diff -u) > > Could you re-post your patch in unified format please? > > Thanks, > Hetz > > On 4/22/07, Wang Cheng Yeh < cywang.eda@gmail.com> wrote: > > The number of responded bytes from scsi device do not match the expected > > value of lsi53c895a driver. > > hence, the mismatch interrupt happen, but the driver does not always > handle > > it correctly. > > My patch make the responded bytes as expected and the interrupt will not > > happen. > > > > Index: hw/scsi-disk.c > > =================================================================== > > RCS file: /sources/qemu/qemu/hw/scsi-disk.c,v > > retrieving revision 1.13 > > diff -r1.13 scsi-disk.c > > 359c359 > > < memset(outbuf, 0, 36); > > --- > > > memset(outbuf, 0, len); > > 377c377 > > < r->buf_len = 36; > > --- > > > r->buf_len = len; > > 442a443,446 > > > for(;r->buf_lenbuf_len++) > > > { > > > *p++=0; > > > } > > > > > > > -- > Skepticism is the lazy person's default position. > Visit my blog (hebrew) for things that (sometimes) matter: > http://wp.dad-answers.com > ------=_Part_130824_4110799.1177248163464 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline
I am sorry. The new attached file is created by (cvs diff -up).

2007/4/22, Hetz Ben Hamo < hetzbh@gmail.com>:
The "standard" way to submitting patches is unified diff's (diff -u)

Could you re-post your patch in unified format please?

Thanks,
Hetz

On 4/22/07, Wang Cheng Yeh < cywang.eda@gmail.com> wrote:
> The number of responded bytes from scsi device do not match the expected
> value of lsi53c895a driver.
> hence, the mismatch interrupt happen, but the driver does not always handle
> it correctly.
> My patch make the responded bytes as expected and the interrupt will not
> happen.
>
> Index: hw/scsi-disk.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/scsi-disk.c,v
> retrieving revision 1.13
> diff -r1.13 scsi-disk.c
> 359c359
> <       memset(outbuf, 0, 36);
> ---
> >       memset(outbuf, 0, len);
> 377c377
> <       r->buf_len = 36;
> ---
> >       r->buf_len = len;
> 442a443,446
> >             for(;r->buf_len<len;r->buf_len++)
> >             {
> >                 *p++=0;
> >             }
>
>


--
Skepticism is the lazy person's default position.
Visit my blog (hebrew) for things that (sometimes) matter:
http://wp.dad-answers.com


------=_Part_130824_4110799.1177248163464-- ------=_Part_130823_30825521.1177248163464 Content-Type: text/plain; name=tmp.txt; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f0tit3va Content-Disposition: attachment; filename="tmp.txt" SW5kZXg6IGh3L3Njc2ktZGlzay5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3FlbXUv cWVtdS9ody9zY3NpLWRpc2suYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMwpkaWZmIC11IC1w IC1yMS4xMyBzY3NpLWRpc2suYwotLS0gaHcvc2NzaS1kaXNrLmMJMjkgQXVnIDIwMDYgMDQ6NTI6 MTYgLTAwMDAJMS4xMworKysgaHcvc2NzaS1kaXNrLmMJMjIgQXByIDIwMDcgMTM6MTE6NDkgLTAw MDAKQEAgLTM1Niw3ICszNTYsNyBAQCBpbnQzMl90IHNjc2lfc2VuZF9jb21tYW5kKFNDU0lEZXZp Y2UgKnMsCiAgICAgICAgIGlmIChsZW4gPCAzNikgewogICAgICAgICAgICAgQkFERigiSW5xdWly eSBidWZmZXIgdG9vIHNtYWxsICglZClcbiIsIGxlbik7CiAgICAgICAgIH0KLQltZW1zZXQob3V0 YnVmLCAwLCAzNik7CisJbWVtc2V0KG91dGJ1ZiwgMCwgbGVuKTsKIAlpZiAoYmRydl9nZXRfdHlw ZV9oaW50KHMtPmJkcnYpID09IEJEUlZfVFlQRV9DRFJPTSkgewogCSAgICBvdXRidWZbMF0gPSA1 OwogICAgICAgICAgICAgb3V0YnVmWzFdID0gMHg4MDsKQEAgLTM3NCw3ICszNzQsNyBAQCBpbnQz Ml90IHNjc2lfc2VuZF9jb21tYW5kKFNDU0lEZXZpY2UgKnMsCiAJb3V0YnVmWzRdID0gMzI7CiAg ICAgICAgIC8qIFN5bmMgZGF0YSB0cmFuc2ZlciBhbmQgVENRLiAgKi8KICAgICAgICAgb3V0YnVm WzddID0gMHgxMCB8IChzLT50Y3EgPyAweDAyIDogMCk7Ci0Jci0+YnVmX2xlbiA9IDM2OworCXIt PmJ1Zl9sZW4gPSBsZW47CiAJYnJlYWs7CiAgICAgY2FzZSAweDE2OgogICAgICAgICBEUFJJTlRG KCJSZXNlcnZlKDYpXG4iKTsKQEAgLTQ0MCw2ICs0NDAsMTAgQEAgaW50MzJfdCBzY3NpX3NlbmRf Y29tbWFuZChTQ1NJRGV2aWNlICpzLAogICAgICAgICAgICAgICAgIHAgKz0gMjE7CiAgICAgICAg ICAgICB9CiAgICAgICAgICAgICByLT5idWZfbGVuID0gcCAtIG91dGJ1ZjsKKyAgICAgICAgICAg IGZvcig7ci0+YnVmX2xlbjxsZW47ci0+YnVmX2xlbisrKQorICAgICAgICAgICAgeworICAgICAg ICAgICAgICAgICpwKys9MDsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIG91dGJ1ZlswXSA9 IHItPmJ1Zl9sZW4gLSA0OwogICAgICAgICAgICAgaWYgKHItPmJ1Zl9sZW4gPiBsZW4pCiAgICAg ICAgICAgICAgICAgci0+YnVmX2xlbiA9IGxlbjsK ------=_Part_130823_30825521.1177248163464--