From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] vl, qemu-config: remove -set
Date: Wed, 11 Nov 2020 16:48:49 +0100 [thread overview]
Message-ID: <a210eaa2-6d2c-0d7c-d7e3-96c73acaf6b0@redhat.com> (raw)
In-Reply-To: <20201111150336.GF906488@redhat.com>
On 11/11/20 16:03, Daniel P. Berrangé wrote:
> iotest 068 uses -set and qtest vhost-user-text.c also does
>
> IOW, it looks like it is valid to use -set, even if you're not using
> -readconfig.
>
> Libvirt doesn't use -set, but we've had users who make use of libvirt
> command line passthrough for QEMU with -set.
Hmm, indeed:
https://patchwork.kernel.org/project/qemu-devel/patch/20181218041625.24969-16-mst@redhat.com/
> IOW, I'm not convinced real world usage is near zero as suggested.
Yes, perhaps it's not. :) Though for both tests you pointed out it's
even cleaner not to use it, there seems to be real world usage at least
with "device".
It is probably more viable to deprecate or even forbid usage of "-set"
with anything but "device". vhost-user-test.c would still be affected,
but it's a relatively small patch.
Paolo
next prev parent reply other threads:[~2020-11-11 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 13:57 [PATCH] vl, qemu-config: remove -set Paolo Bonzini
2020-11-11 15:03 ` Daniel P. Berrangé
2020-11-11 15:48 ` Paolo Bonzini [this message]
2020-11-12 6:55 ` Markus Armbruster
2020-11-12 7:08 ` Paolo Bonzini
2020-11-12 11:26 ` Gerd Hoffmann
2020-11-12 13:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a210eaa2-6d2c-0d7c-d7e3-96c73acaf6b0@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).