From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] nbd: generalize usage of nbd_read
Date: Fri, 1 Feb 2019 12:34:36 -0600 [thread overview]
Message-ID: <a24a7b8b-83ce-3787-162f-ace7c09d362c@redhat.com> (raw)
In-Reply-To: <eb482fb2-5934-c786-1b23-f46054bbdb39@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On 2/1/19 12:27 PM, Eric Blake wrote:
>
>
>> +
>> +#define DEF_NBD_READ(bits) \
>> +static inline int nbd_read ## bits(QIOChannel *ioc, uint ## bits ## _t * val, \
>
> checkpatch didn't flag it, but I think our style is '*val', not '* val'.
But it DOES flag '*val' as a false positive. Oh well.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-01 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 16:58 [Qemu-devel] [PATCH] nbd: generalize usage of nbd_read Vladimir Sementsov-Ogievskiy
2019-02-01 18:27 ` Eric Blake
2019-02-01 18:34 ` Eric Blake [this message]
2019-02-03 16:01 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a24a7b8b-83ce-3787-162f-ace7c09d362c@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).