From: "Cédric Le Goater" <clg@kaod.org>
To: Luis Fernando Fujita Pires <luis.pires@eldorado.org.br>,
Matheus Kowalczuk Ferst <matheus.ferst@eldorado.org.br>,
QEMU Developers <qemu-devel@nongnu.org>,
QEMU PowerPC <qemu-ppc@nongnu.org>
Subject: Re: Fwd: New Defects reported by Coverity Scan for QEMU
Date: Wed, 17 Nov 2021 11:34:52 +0100 [thread overview]
Message-ID: <a25473d6-9bff-db32-c6e2-e19ef0b33ecc@kaod.org> (raw)
In-Reply-To: <CPXPR80MB5224B99CDBDD24B81FF4CC58DA999@CPXPR80MB5224.lamprd80.prod.outlook.com>
On 11/16/21 21:21, Luis Fernando Fujita Pires wrote:
> From: Matheus K. Ferst <matheus.ferst@eldorado.org.br>
>> Hi Cédric,
>>
>> The only change was the helper name that is now uppercase, so nothing new
>> here. The underlying cause is that dfp_finalize_decimal64 only sets
>> dfp->vt.VsrD(1) and set_dfp64 receives a pointer to the complete struct.
>>
>> But since set_dfp64 also only access VsrD(1), it shouldn't be a real
>> problem AFAICT. The same applies to CID 1465776~1465786 and
>> 1465788~1465790.
>
> Right. Coverity is probably reporting these as new just because the helper macros were re-written as part of the move to decodetree.
> I believe these should be marked as false positives.
>
> We *could* also wrap set_dfp{64,128} in new macros that would then reference only the appropriate parts of dfp, but, in this case, I don't think it's worth the trouble.
Thanks for the help on this,
C.
prev parent reply other threads:[~2021-11-17 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <618af1a42c458_27197b2b2515bd79b8920c6@prd-scan-dashboard-0.mail>
2021-11-10 8:18 ` Fwd: New Defects reported by Coverity Scan for QEMU Cédric Le Goater
2021-11-12 16:28 ` Matheus K. Ferst
2021-11-16 20:21 ` Luis Fernando Fujita Pires
2021-11-17 10:34 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25473d6-9bff-db32-c6e2-e19ef0b33ecc@kaod.org \
--to=clg@kaod.org \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).