From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Finn Thain <fthain@telegraphics.com.au>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-stable@nongnu.org
Subject: Re: [PATCH v4 13/14] dp8393x: Don't reset Silicon Revision register
Date: Wed, 29 Jan 2020 17:37:41 +0100 [thread overview]
Message-ID: <a25e9fd2-4d3b-318c-1da5-b1de1d349ac1@redhat.com> (raw)
In-Reply-To: <61d9753b631e9071809cdd1bb8e12385aa06c83e.1580290069.git.fthain@telegraphics.com.au>
On 1/29/20 10:27 AM, Finn Thain wrote:
> The jazzsonic driver in Linux uses the Silicon Revision register value
> to probe the chip. The driver fails unless the SR register contains 4.
> Unfortunately, reading this register in QEMU usually returns 0 because
> the s->regs[] array gets wiped after a software reset.
>
> Fixes: bd8f1ebce4 ("net/dp8393x: fix hardware reset")
> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> Changed since v3:
> - Simplified as per suggestion from Philippe Mathieu-Daudé.
> ---
> hw/net/dp8393x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
> index 1b73a8703b..93eb07e6c8 100644
> --- a/hw/net/dp8393x.c
> +++ b/hw/net/dp8393x.c
> @@ -919,6 +919,7 @@ static void dp8393x_reset(DeviceState *dev)
> timer_del(s->watchdog);
>
> memset(s->regs, 0, sizeof(s->regs));
> + s->regs[SONIC_SR] = 0x0004; /* only revision recognized by Linux/mips */
> s->regs[SONIC_CR] = SONIC_CR_RST | SONIC_CR_STP | SONIC_CR_RXDIS;
> s->regs[SONIC_DCR] &= ~(SONIC_DCR_EXBUS | SONIC_DCR_LBR);
> s->regs[SONIC_RCR] &= ~(SONIC_RCR_LB0 | SONIC_RCR_LB1 | SONIC_RCR_BRD | SONIC_RCR_RNT);
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> @@ -971,7 +972,6 @@ static void dp8393x_realize(DeviceState *dev, Error **errp)
> qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a);
>
> s->watchdog = timer_new_ns(QEMU_CLOCK_VIRTUAL, dp8393x_watchdog, s);
> - s->regs[SONIC_SR] = 0x0004; /* only revision recognized by Linux */
>
> memory_region_init_ram(&s->prom, OBJECT(dev),
> "dp8393x-prom", SONIC_PROM_SIZE, &local_err);
>
next prev parent reply other threads:[~2020-01-29 16:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 9:27 [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation Finn Thain
2020-01-29 9:27 ` [PATCH v4 10/14] dp8393x: Pad frames to word or long word boundary Finn Thain
2020-01-29 9:27 ` [PATCH v4 07/14] dp8393x: Implement packet size limit and RBAE interrupt Finn Thain
2020-01-29 9:27 ` [PATCH v4 09/14] dp8393x: Use long-word-aligned RRA pointers in 32-bit mode Finn Thain
2020-01-29 9:27 ` [PATCH v4 02/14] dp8393x: Always use 32-bit accesses Finn Thain
2020-01-29 9:27 ` [PATCH v4 08/14] dp8393x: Don't clobber packet checksum Finn Thain
2020-01-29 9:27 ` [PATCH v4 11/14] dp8393x: Clear descriptor in_use field to release packet Finn Thain
2020-01-29 9:27 ` [PATCH v4 13/14] dp8393x: Don't reset Silicon Revision register Finn Thain
2020-01-29 16:37 ` Philippe Mathieu-Daudé [this message]
2020-01-29 9:27 ` [PATCH v4 12/14] dp8393x: Always update RRA pointers and sequence numbers Finn Thain
2020-01-29 9:27 ` [PATCH v4 14/14] dp8393x: Don't stop reception upon RBE interrupt assertion Finn Thain
2020-01-29 9:27 ` [PATCH v4 04/14] dp8393x: Have dp8393x_receive() return the packet size Finn Thain
2020-01-29 9:27 ` [PATCH v4 01/14] dp8393x: Mask EOL bit from descriptor addresses Finn Thain
2020-01-29 9:27 ` [PATCH v4 06/14] dp8393x: Clear RRRA command register bit only when appropriate Finn Thain
2020-01-29 9:27 ` [PATCH v4 03/14] dp8393x: Clean up endianness hacks Finn Thain
2020-01-29 9:27 ` [PATCH v4 05/14] dp8393x: Update LLFA and CRDA registers from rx descriptor Finn Thain
2020-01-29 16:38 ` Philippe Mathieu-Daudé
2020-02-04 3:58 ` [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation Jason Wang
2020-02-18 18:30 ` Aleksandar Markovic
2020-02-19 3:13 ` Jason Wang
2020-02-18 18:25 ` Aleksandar Markovic
2020-02-19 1:06 ` Finn Thain
2020-02-19 1:54 ` Aleksandar Markovic
2020-02-19 1:57 ` Aleksandar Markovic
2020-02-19 7:55 ` Laurent Vivier
2020-02-19 8:27 ` Philippe Mathieu-Daudé
2020-02-20 6:55 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25e9fd2-4d3b-318c-1da5-b1de1d349ac1@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=fthain@telegraphics.com.au \
--cc=hpoussin@reactos.org \
--cc=jasowang@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).