From: Thomas Huth <thuth@redhat.com>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 5/9] tests/qtest: Introduce qtest_resolve_machine_alias
Date: Wed, 11 Oct 2023 17:25:38 +0200 [thread overview]
Message-ID: <a262224f-c568-45dd-8f52-b30dee28dfd3@redhat.com> (raw)
In-Reply-To: <20231006123910.17759-6-farosas@suse.de>
On 06/10/2023 14.39, Fabiano Rosas wrote:
> The migration tests are being enhanced to test migration between
> different QEMU versions. A requirement of migration is that the
> machine type between source and destination matches, including the
> version.
>
> We cannot hardcode machine types in the tests because those change
> with each release. QEMU provides a machine type alias that has a fixed
> name, but points to the latest machine type at each release.
>
> Add a helper to resolve the alias into the exact machine
> type. E.g. "-machine pc" resolves to "pc-i440fx-8.2"
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/qtest/libqtest.c | 16 ++++++++++++++++
> tests/qtest/libqtest.h | 10 ++++++++++
> 2 files changed, 26 insertions(+)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-10-11 15:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:39 [PATCH v2 0/9] tests/migration-test: Allow testing older machine types Fabiano Rosas
2023-10-06 12:39 ` [PATCH v2 1/9] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable Fabiano Rosas
2023-10-11 14:17 ` Juan Quintela
2023-10-11 14:30 ` Thomas Huth
2023-10-11 14:32 ` Juan Quintela
2023-10-11 14:55 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 2/9] tests/qtest: Introduce qtest_init_with_env Fabiano Rosas
2023-10-11 14:20 ` Juan Quintela
2023-10-11 14:56 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 3/9] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary Fabiano Rosas
2023-10-11 14:22 ` Juan Quintela
2023-10-11 15:05 ` Thomas Huth
2023-10-12 7:49 ` Thomas Huth
2023-10-12 14:53 ` Fabiano Rosas
2023-10-16 16:00 ` Fabiano Rosas
2023-10-06 12:39 ` [PATCH v2 4/9] tests/qtest: Introduce qtest_has_machine_with_env Fabiano Rosas
2023-10-11 14:22 ` Juan Quintela
2023-10-11 15:06 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 5/9] tests/qtest: Introduce qtest_resolve_machine_alias Fabiano Rosas
2023-10-11 14:23 ` Juan Quintela
2023-10-11 15:25 ` Thomas Huth [this message]
2023-10-11 15:47 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 6/9] tests/qtest/migration: Introduce find_common_machine_version Fabiano Rosas
2023-10-11 14:25 ` Juan Quintela
2023-10-11 15:50 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 7/9] tests/qtest/migration: Define a machine for all architectures Fabiano Rosas
2023-10-11 14:28 ` Juan Quintela
2023-10-11 14:40 ` Fabiano Rosas
2023-10-11 14:48 ` Daniel P. Berrangé
2023-10-11 14:59 ` Fabiano Rosas
2023-10-17 12:53 ` Fabiano Rosas
2023-10-11 15:55 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 8/9] tests/qtest/migration: Support more than one QEMU binary Fabiano Rosas
2023-10-11 14:31 ` Juan Quintela
2023-10-06 12:39 ` [PATCH v2 9/9] tests/qtest: Don't print messages from query instances Fabiano Rosas
2023-10-11 14:31 ` Juan Quintela
2023-10-11 15:59 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a262224f-c568-45dd-8f52-b30dee28dfd3@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).