From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org
Subject: Re: [PATCH 12/26] target/s390x: Move masking of psw.addr to cpu_get_tb_cpu_state
Date: Sat, 5 Nov 2022 09:27:07 +1100 [thread overview]
Message-ID: <a26b177e-6e5b-cc73-0b48-04b3c36eb028@linaro.org> (raw)
In-Reply-To: <20221103134213.6h2lcmwcs6hykirt@heavy>
On 11/4/22 00:42, Ilya Leoshkevich wrote:
> On Wed, Oct 05, 2022 at 08:44:07PM -0700, Richard Henderson wrote:
>> Masking after the fact in s390x_tr_init_disas_context
>> provides incorrect information to tb_lookup.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> target/s390x/cpu.h | 13 +++++++------
>> target/s390x/tcg/translate.c | 6 ------
>> 2 files changed, 7 insertions(+), 12 deletions(-)
>
> How can we end up in a situation where this matters? E.g. if we are in
> 64-bit mode and execute
>
> 0xa12345678: sam31
>
> we will get a specification exception, and cpu_get_tb_cpu_state() will
> not run. And for valid 31-bit addresses masking should be a no-op.
Ah, true. I was mislead by the presence of the code in s390x_tr_init_disas_context.
Perhaps a tcg_debug_assert or just a comment?
r~
next prev parent reply other threads:[~2022-11-04 22:27 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 3:43 [PATCH 00/26] target/s390x: pc-relative translation blocks Richard Henderson
2022-10-06 3:43 ` [PATCH 01/26] target/s390x: Use tcg_constant_* in local contexts Richard Henderson
2022-11-03 10:38 ` Ilya Leoshkevich
2022-10-06 3:43 ` [PATCH 02/26] target/s390x: Use tcg_constant_* for DisasCompare Richard Henderson
2022-11-03 10:54 ` Ilya Leoshkevich
2022-10-06 3:43 ` [PATCH 03/26] target/s390x: Use tcg_constant_i32 for fpinst_extract_m34 Richard Henderson
2022-11-03 10:56 ` Ilya Leoshkevich
2022-10-06 3:43 ` [PATCH 04/26] target/s390x: Use tcg_constant_* in translate_vx.c.inc Richard Henderson
2022-11-03 11:04 ` Ilya Leoshkevich
2022-11-03 23:05 ` Richard Henderson
2022-10-06 3:44 ` [PATCH 05/26] target/s390x: Change help_goto_direct to work on displacements Richard Henderson
2022-11-03 11:13 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 06/26] target/s390x: Introduce gen_psw_addr_disp Richard Henderson
2022-11-03 11:22 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 07/26] target/s390x: Remove pc argument to pc_to_link_into Richard Henderson
2022-11-03 11:23 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 08/26] target/s390x: Use gen_psw_addr_disp in pc_to_link_info Richard Henderson
2022-11-03 11:26 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 09/26] target/s390x: Use gen_psw_addr_disp in save_link_info Richard Henderson
2022-11-03 12:52 ` Ilya Leoshkevich
2022-11-03 13:00 ` [PATCH] tests/tcg/s390x: Add bal.S Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 10/26] target/s390x: Use gen_psw_addr_disp in op_sam Richard Henderson
2022-11-03 13:11 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 11/26] target/s390x: Use ilen instead in branches Richard Henderson
2022-11-03 13:13 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 12/26] target/s390x: Move masking of psw.addr to cpu_get_tb_cpu_state Richard Henderson
2022-11-03 13:42 ` Ilya Leoshkevich
2022-11-04 22:27 ` Richard Henderson [this message]
2022-11-29 1:49 ` Ilya Leoshkevich
2022-11-29 1:53 ` [PATCH] tests/tcg/s390x: Add sam.S Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 13/26] target/s390x: Add disp argument to update_psw_addr Richard Henderson
2022-11-03 13:44 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 14/26] target/s390x: Don't set gbea for user-only Richard Henderson
2022-11-03 13:46 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 15/26] target/s390x: Introduce per_enabled Richard Henderson
2022-11-03 13:47 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 16/26] target/s390x: Disable conditional branch-to-next for PER Richard Henderson
2022-11-03 14:32 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 17/26] target/s390x: Introduce help_goto_indirect Richard Henderson
2022-11-30 10:15 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 18/26] target/s390x: Split per_branch Richard Henderson
2022-11-03 14:45 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 19/26] target/s390x: Simplify help_branch Richard Henderson
2022-11-30 12:06 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 20/26] target/s390x: Split per_breaking_event from per_branch_* Richard Henderson
2022-11-30 12:14 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 21/26] target/s390x: Remove PER check from use_goto_tb Richard Henderson
2022-11-30 17:33 ` Ilya Leoshkevich
2022-11-30 17:46 ` [PATCH 1/2] target/s390x: Fix successful-branch PER events Ilya Leoshkevich
2022-11-30 17:46 ` [PATCH 2/2] tests/tcg/s390x: Add per.S Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 22/26] target/s390x: Pass original r2 register to BCR Richard Henderson
2022-11-30 17:53 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 23/26] tcg: Pass TCGTempKind to tcg_temp_new_internal Richard Henderson
2022-11-30 17:56 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 24/26] tcg: Introduce tcg_temp_ebb_new_* Richard Henderson
2022-11-30 18:07 ` Ilya Leoshkevich
2022-11-30 21:09 ` Richard Henderson
2022-12-01 19:13 ` Alex Bennée
2022-12-01 20:34 ` Richard Henderson
2022-10-06 3:44 ` [PATCH 25/26] tcg: Introduce tcg_temp_is_normal_* Richard Henderson
2022-11-30 18:07 ` Ilya Leoshkevich
2022-10-06 3:44 ` [PATCH 26/26] target/s390x: Enable TARGET_TB_PCREL Richard Henderson
2022-10-24 23:04 ` [PATCH 00/26] target/s390x: pc-relative translation blocks Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a26b177e-6e5b-cc73-0b48-04b3c36eb028@linaro.org \
--to=richard.henderson@linaro.org \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).