From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9Er6-0008Nn-Uk for qemu-devel@nongnu.org; Sat, 04 Jun 2016 12:55:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9Er2-000122-Sz for qemu-devel@nongnu.org; Sat, 04 Jun 2016 12:55:24 -0400 Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]:36278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9Er2-00011y-Lb for qemu-devel@nongnu.org; Sat, 04 Jun 2016 12:55:20 -0400 Received: by mail-pa0-x22a.google.com with SMTP id te7so19602019pab.3 for ; Sat, 04 Jun 2016 09:55:20 -0700 (PDT) Sender: Richard Henderson References: <1464562768-8954-1-git-send-email-peer.adelt@c-lab.de> <1464562768-8954-3-git-send-email-peer.adelt@c-lab.de> From: Richard Henderson Message-ID: Date: Sat, 4 Jun 2016 09:55:17 -0700 MIME-Version: 1.0 In-Reply-To: <1464562768-8954-3-git-send-email-peer.adelt@c-lab.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] target-tricore: Added MADD.F and MSUB.F instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peer.adelt@c-lab.de, qemu-devel@nongnu.org Cc: kbastian@mail.uni-paderborn.de On 05/29/2016 03:59 PM, peer.adelt@c-lab.de wrote: > + flags = f_get_excp_flags(env); > + f_result = float32_muladd(-arg1, arg2, arg3, flags, &env->fp_status); Bastian already pointed out that flags here is being used wrong, but I thought I'd reinforce that "-arg1" is not how floating-point negation works. You need to use float_muladd_negate_product as that 4th argument to float32_muladd. r~