From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw/pci: Remove unused pci_irq_pulse() method
Date: Fri, 22 Nov 2024 13:38:22 +0100 [thread overview]
Message-ID: <a2833980-6a67-40bd-8b19-7cd5e9322df7@redhat.com> (raw)
In-Reply-To: <20241122103418.539-1-philmd@linaro.org>
On 22/11/2024 11.34, Philippe Mathieu-Daudé wrote:
> Last use of pci_irq_pulse() was removed 7 years ago in commit
> 5e9aa92eb1 ("hw/block: Fix pin-based interrupt behaviour of NVMe").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/pci/pci.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index 135695c551..c0717e3121 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -670,16 +670,6 @@ static inline void pci_irq_deassert(PCIDevice *pci_dev)
> pci_set_irq(pci_dev, 0);
> }
>
> -/*
> - * FIXME: PCI does not work this way.
> - * All the callers to this method should be fixed.
> - */
> -static inline void pci_irq_pulse(PCIDevice *pci_dev)
> -{
> - pci_irq_assert(pci_dev);
> - pci_irq_deassert(pci_dev);
> -}
> -
> MSIMessage pci_get_msi_message(PCIDevice *dev, int vector);
> void pci_set_power(PCIDevice *pci_dev, bool state);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2024-11-22 12:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 10:34 [PATCH] hw/pci: Remove unused pci_irq_pulse() method Philippe Mathieu-Daudé
2024-11-22 12:38 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2833980-6a67-40bd-8b19-7cd5e9322df7@redhat.com \
--to=thuth@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).