From: Richard Henderson <rth@twiddle.net>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org, benh@kernel.crashing.org,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/9] target-ppc: Implement mtvsrdd instruction
Date: Wed, 28 Sep 2016 09:01:18 -0700 [thread overview]
Message-ID: <a2912e18-bfd8-2f26-38bd-e47e40a4e01a@twiddle.net> (raw)
In-Reply-To: <1475040687-27523-3-git-send-email-nikunj@linux.vnet.ibm.com>
On 09/27/2016 10:31 PM, Nikunj A Dadhania wrote:
> + if (!rA(ctx->opcode)) {
> + tcg_gen_movi_i64(cpu_vsrh(xT(ctx->opcode)), 0);
> + } else {
> + tcg_gen_mov_i64(cpu_vsrh(xT(ctx->opcode)), cpu_gpr[rA(ctx->opcode)]);
> + }
Indentation. Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2016-09-28 16:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 5:31 [Qemu-devel] [PATCH v4 0/9] POWER9 TCG enablements - part4 Nikunj A Dadhania
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 1/9] target-ppc: Implement mfvsrld instruction Nikunj A Dadhania
2016-09-28 16:03 ` Richard Henderson
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 2/9] target-ppc: Implement mtvsrdd instruction Nikunj A Dadhania
2016-09-28 16:01 ` Richard Henderson [this message]
2016-09-28 17:06 ` Nikunj A Dadhania
2016-09-29 1:29 ` David Gibson
2016-09-29 3:20 ` Nikunj A Dadhania
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 3/9] target-ppc: Implement mtvsrws instruction Nikunj A Dadhania
2016-09-28 16:04 ` Richard Henderson
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 4/9] target-ppc: improve lxvw4x implementation Nikunj A Dadhania
2016-09-28 16:07 ` Richard Henderson
2016-09-29 1:38 ` David Gibson
2016-09-29 2:34 ` Nikunj A Dadhania
2016-09-29 3:41 ` Nikunj A Dadhania
2016-09-29 3:48 ` Richard Henderson
2016-09-29 3:57 ` David Gibson
2016-09-29 3:55 ` David Gibson
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 5/9] target-ppc: improve stxvw4x implementation Nikunj A Dadhania
2016-09-28 16:08 ` Richard Henderson
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 6/9] target-ppc: add lxvh8x instruction Nikunj A Dadhania
2016-09-28 16:12 ` Richard Henderson
2016-09-28 17:11 ` Nikunj A Dadhania
2016-09-28 17:22 ` Richard Henderson
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 7/9] target-ppc: add stxvh8x instruction Nikunj A Dadhania
2016-09-28 16:13 ` Richard Henderson
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 8/9] target-ppc: add lxvb16x instruction Nikunj A Dadhania
2016-09-28 16:13 ` Richard Henderson
2016-09-28 5:31 ` [Qemu-devel] [PATCH v4 9/9] target-ppc: add stxvb16x instruction Nikunj A Dadhania
2016-09-28 16:13 ` Richard Henderson
2016-09-28 5:38 ` [Qemu-devel] [PATCH v4 0/9] POWER9 TCG enablements - part4 Nikunj A Dadhania
2016-09-28 9:28 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2016-09-28 11:34 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2912e18-bfd8-2f26-38bd-e47e40a4e01a@twiddle.net \
--to=rth@twiddle.net \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).