Re: [PATCH] avocado: use sha1 for fc31 imgs to avoid first time re-download

[Daniel Henrique Barboza <danielhb413@gmail.com>]

On 10/24/22 06:02, Daniel P. Berrangé wrote:
> On Sat, Oct 22, 2022 at 02:03:50PM -0300, Daniel Henrique Barboza wrote:
>> 'make check-avocado' will download any images that aren't present in the
>> cache via 'get-vm-images' in tests/Makefile.include. The target that
>> downloads fedora 31 images, get-vm-image-fedora-31, will use 'avocado
>> vmimage get  --distro=fedora --distro-version=31 --arch=(...)' to
>> download the image for each arch. Note that this command does not
>> support any argument to set the hash algorithm used and, based on the
>> avocado source code [1], DEFAULT_HASH_ALGORITHM is set to "sha1". The
>> sha1 hash is stored in a Fedora-Cloud-Base-31-1.9.{ARCH}.qcow2-CHECKSUM
>> in the cache.
> 
>> For now, in QEMU, let's use sha1 for all Fedora 31 images. This will
>> immediately spares us at least one extra download for each Fedora 31
>> image that we're doing in all our CI runs.
>>
>> [1] https://github.com/avocado-framework/avocado.git @ 942a5d6972906
>> [2] https://github.com/avocado-framework/avocado/issues/5496
> 
> Can we just ask Avocado maintainers to fix this problem on their
> side to allow use of a modern hash alg as a priority item. We've
> already had this problem in QEMU for over a year AFAICT, so doesn't
> seem like we need to urgently do a workaround on QEMU side, so we
> can get Avocado devs to commit to fixing it in the next month.

Sure, I think it would be better if we can get an Avocado side fix to make
the current QEMU usage viable.

For now I'll use this patch locally because this issue is 100% reproducible
on my home machine :( apparently my internet is capable of 4k streaming but,
for some reason, it doesn't manage to download 350Mb from the Fedora mirror
in less that 180 seconds. 'make check-avocado' always gives me a timeout in
'test_pseries_tcg'.


Thanks,


Daniel

> 
> 
> With regards,
> Daniel