From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10119C25B75 for ; Thu, 23 May 2024 14:52:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA9n2-0007fg-PF; Thu, 23 May 2024 10:51:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA9n0-0007bo-Ku for qemu-devel@nongnu.org; Thu, 23 May 2024 10:51:30 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sA9my-0002vd-9N for qemu-devel@nongnu.org; Thu, 23 May 2024 10:51:30 -0400 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6f43ee95078so3720298b3a.1 for ; Thu, 23 May 2024 07:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716475886; x=1717080686; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qSFAlNjazZM3ovQ+0GrczowV9ckEVjnH2fjHWTfZhRs=; b=u8DfTefeRIbc6cTvXRMqryIFdVkEn59oBkdj9LTsJ0RNrNnA5MbzXL2bC53mEWfxXi lXIgEfCSKKvSHmzEIqrjQ07qOl/felWLs7czgyzS6E8QzxufoKUm5taioSlV/NVsDbSp aYOBxTSRjAtjDMV416pMQY8KIXDj9RiTWsrP08hFIX4R49jzH0KbNvPgVQHRFjiHmtDi L//3AlSBY1afTjTlay0oFeChFY4IXoX/p9pXQTCsJNw/yMX6wlshVHDb18+0+UiHFYvU ldDNdQxF6zLDbbB99cZnfFcaFVu0phLk3VtJa5bDlcLxTADg6IhdHYmUaze8ThCFWA5z Kx8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716475886; x=1717080686; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qSFAlNjazZM3ovQ+0GrczowV9ckEVjnH2fjHWTfZhRs=; b=o+z3cNocZmpzsBF0Pd0S/nquDulIqoaSqkutyUHvUF+zVLHAZxcI825ScL2ihrjdk2 mw+Lpsi4BCZBSKE9qtrPvkhgl5OItuYxdBnhEqglfnvt2UDt14UwjIlh72ax2/YEwxge crG6Y9on4PaWIITu/+wkttALM3VX6o8NYk9HRAgB2aP8dPUypp+hCZtp4mJu3b2Ksyu5 8sjZtqSrEMNeCyiS4KfZTR3XOo33VkFOt3pN0DJZgAb6bja9BXtj+qKE/zrgt0Cppgpy 9ICInR+D+YQoM+9JDQKef4XKqUCbneF2H2kWaTSZ2v0sGr18wX5Wx08hi3Yv8YeB1T1b iemg== X-Gm-Message-State: AOJu0YyCIEjmWClyE/R/WyssVXmFM27v9x4WRqDXJyqz4V0hW7J+UGPo 4nNvLJshzPUkBwAzWlxxAJrjPke5VNxhufqruq3yHi1MfYcpACpbA+26WvUNfIw= X-Google-Smtp-Source: AGHT+IFVdbKgAJGXyp3pjwt883px8/sJkx1OkxWn+QOK/Re/sz1tNdKJPkMdu6BGRXbtuvGJuO+AjQ== X-Received: by 2002:a05:6a00:2e95:b0:6f3:ea67:48c3 with SMTP id d2e1a72fcca58-6f6d5e6f68amr6680137b3a.0.1716475886037; Thu, 23 May 2024 07:51:26 -0700 (PDT) Received: from [192.168.0.4] (174-21-72-5.tukw.qwest.net. [174.21.72.5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2af2b1esm24902735b3a.171.2024.05.23.07.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 07:51:25 -0700 (PDT) Message-ID: Date: Thu, 23 May 2024 07:51:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 30/57] target/arm: Improve vector UQADD, UQSUB, SQADD, SQSUB To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org References: <20240506010403.6204-1-richard.henderson@linaro.org> <20240506010403.6204-31-richard.henderson@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/23/24 07:14, Peter Maydell wrote: >> void gen_gvec_uqadd_qc(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, >> uint32_t rm_ofs, uint32_t opr_sz, uint32_t max_sz) >> { >> static const TCGOpcode vecop_list[] = { >> - INDEX_op_usadd_vec, INDEX_op_cmp_vec, INDEX_op_add_vec, 0 >> + INDEX_op_usadd_vec, INDEX_op_add_vec, 0 >> }; > > Why don't we need to add XOR to this list? Is it because we can > assume we have XOR-of-vector on all vector-capable hosts? Correct. There's an assert in tcg_can_emit_vecop_list that (1) baseline vector ops are *not* included in the list, and (2) all other ops *are* included in the list. r~