From: Mihai Carabas <mihai.carabas@oracle.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Yan Vugenfirer <yvugenfi@redhat.com>
Cc: peter.maydell@linaro.org,
QEMU Devel Mailing List <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/4] hw/misc/pvpanic: add PCI interface support
Date: Wed, 20 Jan 2021 16:05:03 +0200 [thread overview]
Message-ID: <a2b5326d-1dd4-7799-bdfb-e62f9beab3b7@oracle.com> (raw)
In-Reply-To: <20210120134339.h42o3j7utjveeiey@sirius.home.kraxel.org>
La 20.01.2021 15:43, Gerd Hoffmann a scris:
> Hi,
>
>>> + pc->realize = pvpanic_pci_realizefn;
>>> + pc->vendor_id = PCI_VENDOR_ID_REDHAT;
>>> + pc->device_id = PCI_DEVICE_ID_REDHAT_PVPANIC;
>> Please fill out subsystem and subsystem vendor IDs as well:
>> pc->subsystem_vendor_id
>> pc->subsystem_id
> Not needed, when left blank they are set to the default
> qemu subsystem id (1af4:1100) by the pci core.
Thank you!
@Peter: You can grab v4 if this is not needed.
next prev parent reply other threads:[~2021-01-20 14:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 18:34 [PATCH v3] Add support for pvpanic pci device Mihai Carabas
2021-01-15 18:34 ` [PATCH 1/4] hw/misc/pvpanic: split-out generic and bus dependent code Mihai Carabas
2021-01-19 13:12 ` Peter Maydell
2021-01-15 18:34 ` [PATCH 2/4] hw/misc/pvpanic: add PCI interface support Mihai Carabas
2021-01-18 10:00 ` Gerd Hoffmann
2021-01-19 13:14 ` Peter Maydell
2021-01-20 11:57 ` Yan Vugenfirer
2021-01-20 12:49 ` Mihai Carabas
2021-01-20 13:43 ` Gerd Hoffmann
2021-01-20 14:05 ` Mihai Carabas [this message]
2021-01-15 18:34 ` [PATCH 3/4] pvpanic : update pvpanic spec document Mihai Carabas
2021-01-18 10:32 ` Philippe Mathieu-Daudé
2021-01-18 14:36 ` Mihai Carabas
2021-01-19 13:17 ` Peter Maydell
2021-01-15 18:34 ` [PATCH 4/4] tests/qtest: add a test case for pvpanic-pci Mihai Carabas
2021-01-18 7:42 ` Thomas Huth
2021-01-19 13:16 ` Peter Maydell
2021-01-19 13:29 ` [PATCH v3] Add support for pvpanic pci device Peter Maydell
2021-01-19 15:44 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2b5326d-1dd4-7799-bdfb-e62f9beab3b7@oracle.com \
--to=mihai.carabas@oracle.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).