From: Ninad Palsule <ninad@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org, peter.maydell@linaro.org, andrew@aj.id.au,
joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com,
berrange@redhat.com, thuth@redhat.com, philmd@linaro.org
Cc: qemu-arm@nongnu.org
Subject: Re: [PATCH v1 0/7] Introduce model for IBM's FSP
Date: Tue, 29 Aug 2023 21:30:06 -0500 [thread overview]
Message-ID: <a2c31cb2-6cff-4f5f-aa69-2b6ab6f88342@linux.ibm.com> (raw)
In-Reply-To: <587b23ee-4247-c142-9ced-6abd92922b2d@kaod.org>
Hello Cedric,
On 8/28/23 03:49, Cédric Le Goater wrote:
> Hello Ninad,
>
> On 8/25/23 22:30, Ninad Palsule wrote:
>> Hello,
>>
>> Please review the patch-set.
>>
>> This is a first step towards introducing model for IBM's Flexible
>> Service Interface. The full functionality will be implemented over the
>> time.
>>
>> Ninad Palsule (7):
>> hw/fsi: Introduce IBM's Local bus
>> hw/fsi: Introduce IBM's scratchpad
>> hw/fsi: Introduce IBM's cfam,fsi-slave
>> hw/fsi: Introduce IBM's FSI
>> hw/fsi: IBM's On-chip Peripheral Bus
>> hw/fsi: Aspeed APB2OPB interface
>> hw/arm: Hook up FSI module in AST2600
>>
>> hw/Kconfig | 1 +
>> hw/arm/Kconfig | 1 +
>> hw/arm/aspeed_ast2600.c | 15 ++
>> hw/fsi/Kconfig | 23 ++
>> hw/fsi/aspeed-apb2opb.c | 346 +++++++++++++++++++++++++++++
>> hw/fsi/cfam.c | 236 ++++++++++++++++++++
>> hw/fsi/engine-scratchpad.c | 100 +++++++++
>> hw/fsi/fsi-master.c | 202 +++++++++++++++++
>> hw/fsi/fsi-slave.c | 109 +++++++++
>> hw/fsi/fsi.c | 54 +++++
>> hw/fsi/lbus.c | 94 ++++++++
>> hw/fsi/meson.build | 6 +
>> hw/fsi/opb.c | 194 ++++++++++++++++
>> hw/fsi/trace-events | 2 +
>> hw/fsi/trace.h | 1 +
>> hw/meson.build | 1 +
>> include/hw/arm/aspeed_soc.h | 4 +
>> include/hw/fsi/aspeed-apb2opb.h | 32 +++
>> include/hw/fsi/bits.h | 15 ++
>> include/hw/fsi/cfam.h | 59 +++++
>> include/hw/fsi/engine-scratchpad.h | 32 +++
>> include/hw/fsi/fsi-master.h | 30 +++
>> include/hw/fsi/fsi-slave.h | 29 +++
>> include/hw/fsi/fsi.h | 35 +++
>> include/hw/fsi/lbus.h | 57 +++++
>> include/hw/fsi/opb.h | 45 ++++
>> meson.build | 1 +
>
> Thanks for creating a series for these models.
>
> I think the commit logs have a lot of useful information which would
> be good for some docs/specs/ file. Please add a need a entry in
> MAINTAINERS for this new bus model.
>
> Tests are *very* much welcome also. Ideally we should have a couple
> in qtest. A minimum would be an avocado test running pdbg.
I have added document, MAINTAINERS and qtest.
Thank you for the review.
~Ninad
>
> Thanks,
>
> C.
>
>
>
>> 27 files changed, 1724 insertions(+)
>> create mode 100644 hw/fsi/Kconfig
>> create mode 100644 hw/fsi/aspeed-apb2opb.c
>> create mode 100644 hw/fsi/cfam.c
>> create mode 100644 hw/fsi/engine-scratchpad.c
>> create mode 100644 hw/fsi/fsi-master.c
>> create mode 100644 hw/fsi/fsi-slave.c
>> create mode 100644 hw/fsi/fsi.c
>> create mode 100644 hw/fsi/lbus.c
>> create mode 100644 hw/fsi/meson.build
>> create mode 100644 hw/fsi/opb.c
>> create mode 100644 hw/fsi/trace-events
>> create mode 100644 hw/fsi/trace.h
>> create mode 100644 include/hw/fsi/aspeed-apb2opb.h
>> create mode 100644 include/hw/fsi/bits.h
>> create mode 100644 include/hw/fsi/cfam.h
>> create mode 100644 include/hw/fsi/engine-scratchpad.h
>> create mode 100644 include/hw/fsi/fsi-master.h
>> create mode 100644 include/hw/fsi/fsi-slave.h
>> create mode 100644 include/hw/fsi/fsi.h
>> create mode 100644 include/hw/fsi/lbus.h
>> create mode 100644 include/hw/fsi/opb.h
>>
>
prev parent reply other threads:[~2023-08-30 2:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 20:30 [PATCH v1 0/7] Introduce model for IBM's FSP Ninad Palsule
2023-08-25 20:30 ` [PATCH v1 1/7] hw/fsi: Introduce IBM's Local bus Ninad Palsule
2023-08-28 8:34 ` Joel Stanley
2023-08-28 22:55 ` Ninad Palsule
2023-08-25 20:30 ` [PATCH v1 2/7] hw/fsi: Introduce IBM's scratchpad Ninad Palsule
2023-08-28 5:52 ` Thomas Huth
2023-08-29 13:21 ` Ninad Palsule
2023-08-25 20:30 ` [PATCH v1 3/7] hw/fsi: Introduce IBM's cfam,fsi-slave Ninad Palsule
2023-08-28 6:03 ` Thomas Huth
2023-08-29 13:39 ` Ninad Palsule
2023-08-29 13:43 ` Cédric Le Goater
2023-08-30 2:31 ` Ninad Palsule
2023-08-25 20:30 ` [PATCH v1 4/7] hw/fsi: Introduce IBM's FSI Ninad Palsule
2023-08-28 8:57 ` Joel Stanley
2023-08-28 22:58 ` Ninad Palsule
2023-08-25 20:30 ` [PATCH v1 5/7] hw/fsi: IBM's On-chip Peripheral Bus Ninad Palsule
2023-08-28 8:59 ` Joel Stanley
2023-08-28 22:58 ` Ninad Palsule
2023-08-25 20:30 ` [PATCH v1 6/7] hw/fsi: Aspeed APB2OPB interface Ninad Palsule
2023-08-28 8:55 ` Joel Stanley
2023-08-28 22:57 ` Ninad Palsule
2023-08-25 20:30 ` [PATCH v1 7/7] hw/arm: Hook up FSI module in AST2600 Ninad Palsule
2023-08-28 8:48 ` Joel Stanley
2023-08-28 22:56 ` Ninad Palsule
2023-08-28 8:25 ` [PATCH v1 0/7] Introduce model for IBM's FSP Joel Stanley
2023-08-28 21:13 ` Ninad Palsule
2023-08-28 8:49 ` Cédric Le Goater
2023-08-30 2:30 ` Ninad Palsule [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2c31cb2-6cff-4f5f-aa69-2b6ab6f88342@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).