From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 108E4C71153 for ; Wed, 30 Aug 2023 02:30:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbAyN-00014i-M6; Tue, 29 Aug 2023 22:30:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbAyK-000141-7S; Tue, 29 Aug 2023 22:30:21 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbAyH-0002ru-Nt; Tue, 29 Aug 2023 22:30:19 -0400 Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37U29DiL020814; Wed, 30 Aug 2023 02:30:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=nZm+YHYnv3Nr94rX8SYnTJAOFr73oGgMVtJ2+sMBQFE=; b=ownNZIjrcP2evujHnQG0zJXmqgkU0BfTH6z9nYcTvxSgMeLydNp2Ip2h/3o36l+cxYdh xXyp1VE5fsPvvG0W7IxF/GZ//By0aKe/DZccxL2QYPTa5f5V7w9nLG0QyhfdTW894SFW BEsaEYK1OJKALTT9VuKpyEkLTPj4t85JqBw/8yMSGfdY7XtspiSBMRK6uYcWX724oR4V a5v9WsWOpBByiP1Z26Ew4KmZYnL7mPdYtw9tjqYwWhEQ+tdmWkr95nBRicUV07rL9vCn sVXF1vdbV9K9yWoGge4DfcgWDrDLlBN/SOnRG6FUwJRrD1mje8naoheRreJ5UvvSIIo6 bA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ssu57t0cu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Aug 2023 02:30:10 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37U2PsHK012372; Wed, 30 Aug 2023 02:30:10 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ssu57t0cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Aug 2023 02:30:09 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37U1tUEO004884; Wed, 30 Aug 2023 02:30:09 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3squqsrrgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Aug 2023 02:30:09 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37U2U8Yv36372880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Aug 2023 02:30:08 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2979E58051; Wed, 30 Aug 2023 02:30:08 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 88F055805A; Wed, 30 Aug 2023 02:30:06 +0000 (GMT) Received: from [9.61.171.165] (unknown [9.61.171.165]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 30 Aug 2023 02:30:06 +0000 (GMT) Message-ID: Date: Tue, 29 Aug 2023 21:30:06 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/7] Introduce model for IBM's FSP To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, peter.maydell@linaro.org, andrew@aj.id.au, joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com, berrange@redhat.com, thuth@redhat.com, philmd@linaro.org Cc: qemu-arm@nongnu.org References: <20230825203046.3692467-1-ninad@linux.ibm.com> <587b23ee-4247-c142-9ced-6abd92922b2d@kaod.org> Content-Language: en-US From: Ninad Palsule In-Reply-To: <587b23ee-4247-c142-9ced-6abd92922b2d@kaod.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: q34FMqPR3fjnG4GGKE2OSxDRc1qMzJnF X-Proofpoint-ORIG-GUID: --hqRFXirAXdVOjJrOpLo3jyovWvFN1j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-29_16,2023-08-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=603 bulkscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2308300017 Received-SPF: pass client-ip=148.163.158.5; envelope-from=ninad@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hello Cedric, On 8/28/23 03:49, Cédric Le Goater wrote: > Hello Ninad, > > On 8/25/23 22:30, Ninad Palsule wrote: >> Hello, >> >> Please review the patch-set. >> >> This is a first step towards introducing model for IBM's Flexible >> Service Interface. The full functionality will be implemented over the >> time. >> >> Ninad Palsule (7): >>    hw/fsi: Introduce IBM's Local bus >>    hw/fsi: Introduce IBM's scratchpad >>    hw/fsi: Introduce IBM's cfam,fsi-slave >>    hw/fsi: Introduce IBM's FSI >>    hw/fsi: IBM's On-chip Peripheral Bus >>    hw/fsi: Aspeed APB2OPB interface >>    hw/arm: Hook up FSI module in AST2600 >> >>   hw/Kconfig                         |   1 + >>   hw/arm/Kconfig                     |   1 + >>   hw/arm/aspeed_ast2600.c            |  15 ++ >>   hw/fsi/Kconfig                     |  23 ++ >>   hw/fsi/aspeed-apb2opb.c            | 346 +++++++++++++++++++++++++++++ >>   hw/fsi/cfam.c                      | 236 ++++++++++++++++++++ >>   hw/fsi/engine-scratchpad.c         | 100 +++++++++ >>   hw/fsi/fsi-master.c                | 202 +++++++++++++++++ >>   hw/fsi/fsi-slave.c                 | 109 +++++++++ >>   hw/fsi/fsi.c                       |  54 +++++ >>   hw/fsi/lbus.c                      |  94 ++++++++ >>   hw/fsi/meson.build                 |   6 + >>   hw/fsi/opb.c                       | 194 ++++++++++++++++ >>   hw/fsi/trace-events                |   2 + >>   hw/fsi/trace.h                     |   1 + >>   hw/meson.build                     |   1 + >>   include/hw/arm/aspeed_soc.h        |   4 + >>   include/hw/fsi/aspeed-apb2opb.h    |  32 +++ >>   include/hw/fsi/bits.h              |  15 ++ >>   include/hw/fsi/cfam.h              |  59 +++++ >>   include/hw/fsi/engine-scratchpad.h |  32 +++ >>   include/hw/fsi/fsi-master.h        |  30 +++ >>   include/hw/fsi/fsi-slave.h         |  29 +++ >>   include/hw/fsi/fsi.h               |  35 +++ >>   include/hw/fsi/lbus.h              |  57 +++++ >>   include/hw/fsi/opb.h               |  45 ++++ >>   meson.build                        |   1 + > > Thanks for creating a series for these models. > > I think the commit logs have a lot of useful information which would > be good for some docs/specs/ file. Please add a need a entry in > MAINTAINERS for this new bus model. > > Tests are *very* much welcome also. Ideally we should have a couple > in qtest. A minimum would be an avocado test running pdbg. I have added document, MAINTAINERS and qtest. Thank you for the review. ~Ninad > > Thanks, > > C. > > > >>   27 files changed, 1724 insertions(+) >>   create mode 100644 hw/fsi/Kconfig >>   create mode 100644 hw/fsi/aspeed-apb2opb.c >>   create mode 100644 hw/fsi/cfam.c >>   create mode 100644 hw/fsi/engine-scratchpad.c >>   create mode 100644 hw/fsi/fsi-master.c >>   create mode 100644 hw/fsi/fsi-slave.c >>   create mode 100644 hw/fsi/fsi.c >>   create mode 100644 hw/fsi/lbus.c >>   create mode 100644 hw/fsi/meson.build >>   create mode 100644 hw/fsi/opb.c >>   create mode 100644 hw/fsi/trace-events >>   create mode 100644 hw/fsi/trace.h >>   create mode 100644 include/hw/fsi/aspeed-apb2opb.h >>   create mode 100644 include/hw/fsi/bits.h >>   create mode 100644 include/hw/fsi/cfam.h >>   create mode 100644 include/hw/fsi/engine-scratchpad.h >>   create mode 100644 include/hw/fsi/fsi-master.h >>   create mode 100644 include/hw/fsi/fsi-slave.h >>   create mode 100644 include/hw/fsi/fsi.h >>   create mode 100644 include/hw/fsi/lbus.h >>   create mode 100644 include/hw/fsi/opb.h >> >