From: Richard Henderson <richard.henderson@linaro.org>
To: Damien Hedde <damien.hedde@greensocs.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: Re: [PATCH] target/arm: Disable cryptographic instructions when neon is disabled
Date: Tue, 26 Apr 2022 10:13:54 -0700 [thread overview]
Message-ID: <a2deeb44-8497-88b6-2783-50ac233d960f@linaro.org> (raw)
In-Reply-To: <20220426124259.44087-1-damien.hedde@greensocs.com>
On 4/26/22 05:42, Damien Hedde wrote:
> @@ -1587,6 +1587,9 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)
> unset_feature(env, ARM_FEATURE_NEON);
>
> t = cpu->isar.id_aa64isar0;
> + t = FIELD_DP64(t, ID_AA64ISAR0, AES, 0);
> + t = FIELD_DP64(t, ID_AA64ISAR0, SHA1, 0);
> + t = FIELD_DP64(t, ID_AA64ISAR0, SHA2, 0);
> t = FIELD_DP64(t, ID_AA64ISAR0, DP, 0);
> cpu->isar.id_aa64isar0 = t;
Missing SHA3, SM3, SM4. Otherwise, good catch, thanks.
r~
prev parent reply other threads:[~2022-04-26 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 12:42 [PATCH] target/arm: Disable cryptographic instructions when neon is disabled Damien Hedde
2022-04-26 17:13 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2deeb44-8497-88b6-2783-50ac233d960f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=damien.hedde@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).