From: Eric Blake <eblake@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Maran Wilson <maran.wilson@oracle.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, George Kennedy <george.kennedy@oracle.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marc-Andre Lureau <marcandre.lureau@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/4] linuxboot_dma: move common functions in a new header
Date: Fri, 11 Jan 2019 11:55:24 -0600 [thread overview]
Message-ID: <a313ccb0-4c81-5753-6ca7-95b6811d6f5d@redhat.com> (raw)
In-Reply-To: <20190111124742-mutt-send-email-mst@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On 1/11/19 11:48 AM, Michael S. Tsirkin wrote:
>>>
>>>> diff --git a/pc-bios/optionrom/optrom.h b/pc-bios/optionrom/optrom.h
>>>> new file mode 100644
>>>> index 0000000000..36f43b43fd
>>>> --- /dev/null
>>>> +++ b/pc-bios/optionrom/optrom.h
>>>> +#include "../../include/standard-headers/linux/qemu_fw_cfg.h"
>>>
>>> This depends on <stdint.h>, please include it first.
>>
>> Sure.
>>
>>
>> Thanks,
>> Stefano
>
> Better to just pull in qemu/osdep.h
Except that qemu/osdep.h should already have been pulled in by whatever
.c file is including this header. We specifically document that .h files
shouldn't need to include osdep.h (and in turn, anything that osdep.h
already pulls in, like <stdint.h>).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-11 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 13:18 [Qemu-devel] [PATCH 0/4] pvh: add new PVH option rom Stefano Garzarella
2019-01-11 13:18 ` [Qemu-devel] [PATCH 1/4] linuxboot_dma: remove duplicate definitions of FW_CFG Stefano Garzarella
2019-01-11 16:32 ` Stefan Hajnoczi
2019-01-11 13:18 ` [Qemu-devel] [PATCH 2/4] linuxboot_dma: move common functions in a new header Stefano Garzarella
2019-01-11 16:26 ` Stefan Hajnoczi
2019-01-11 17:42 ` Stefano Garzarella
2019-01-11 17:48 ` Michael S. Tsirkin
2019-01-11 17:55 ` Eric Blake [this message]
2019-01-12 18:25 ` Stefano Garzarella
2019-01-13 2:31 ` Eric Blake
2019-01-12 18:18 ` Stefano Garzarella
2019-01-11 13:18 ` [Qemu-devel] [PATCH 3/4] optionrom: add new PVH option rom Stefano Garzarella
2019-01-11 16:31 ` Stefan Hajnoczi
2019-01-11 13:18 ` [Qemu-devel] [PATCH 4/4] hw/i386/pc: use " Stefano Garzarella
2019-01-11 16:34 ` Stefan Hajnoczi
2019-01-14 9:48 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a313ccb0-4c81-5753-6ca7-95b6811d6f5d@redhat.com \
--to=eblake@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ehabkost@redhat.com \
--cc=george.kennedy@oracle.com \
--cc=kraxel@redhat.com \
--cc=maran.wilson@oracle.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sgarzare@redhat.com \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).