From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48231)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ffOOR-0006po-U8
	for qemu-devel@nongnu.org; Tue, 17 Jul 2018 07:43:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ffOOR-0000HU-7L
	for qemu-devel@nongnu.org; Tue, 17 Jul 2018 07:43:47 -0400
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38526 helo=mx1.redhat.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1ffOOR-0000HH-1m
	for qemu-devel@nongnu.org; Tue, 17 Jul 2018 07:43:47 -0400
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
	[10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 9BE3B77885
	for <qemu-devel@nongnu.org>; Tue, 17 Jul 2018 11:43:46 +0000 (UTC)
References: <20180717113402.5510-1-quintela@redhat.com>
	<20180717113402.5510-8-quintela@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <a3179259-f55b-3cc4-086e-1ec4bd422864@redhat.com>
Date: Tue, 17 Jul 2018 13:43:44 +0200
MIME-Version: 1.0
In-Reply-To: <20180717113402.5510-8-quintela@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/25] check: Only test pcnet when it is
 compiled in
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com

On 17.07.2018 13:33, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  tests/Makefile.include | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 560f486416..a039b70f9b 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -215,9 +215,9 @@ check-qtest-pci-y += tests/e1000e-test$(EXESUF)
>  gcov-files-pci-y += hw/net/e1000e.c hw/net/e1000e_core.c
>  check-qtest-pci-y += tests/rtl8139-test$(EXESUF)
>  gcov-files-pci-y += hw/net/rtl8139.c
> -check-qtest-pci-y += tests/pcnet-test$(EXESUF)
> -gcov-files-pci-y += hw/net/pcnet.c
> -gcov-files-pci-y += hw/net/pcnet-pci.c
> +check-qtest-pci-$(CONFIG_PCNET_PCI) += tests/pcnet-test$(EXESUF)
> +gcov-files-pci-$(CONFIG_PCNET_PCI) += hw/net/pcnet.c
> +gcov-files-pci-$(CONFIG_PCNET_PCI) += hw/net/pcnet-pci.c
>  check-qtest-pci-$(CONFIG_EEPRO100_PCI) += tests/eepro100-test$(EXESUF)
>  gcov-files-pci-$(CONFIG_EEPRO100_PCI) += hw/net/eepro100.c
>  check-qtest-pci-$(CONFIG_NE2000_PCI) += tests/ne2000-test$(EXESUF)

Reviewed-by: Thomas Huth <thuth@redhat.com>