From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FE4C2D0A3 for ; Thu, 29 Oct 2020 19:43:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A055E20796 for ; Thu, 29 Oct 2020 19:43:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JPjP4bdd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A055E20796 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYDpn-0003Ou-Kk for qemu-devel@archiver.kernel.org; Thu, 29 Oct 2020 15:43:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYDp5-0002gY-00 for qemu-devel@nongnu.org; Thu, 29 Oct 2020 15:42:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kYDp3-0006Bj-Aj for qemu-devel@nongnu.org; Thu, 29 Oct 2020 15:42:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604000575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6bIlmMhmaE2SxQRJL5QUN1AMQegfGYjT1cmhhSgnCz8=; b=JPjP4bdd3+S3tt/PX7XErHRRM2IKts8yEOlvVcIjNXBljCBZ8UD2ywmN0NjrVeXy/G7RlP 0xAZXeUcSnEBfDvoqmqUTjGdT0PxhpsByFo9YL5Yu6DqcB7yo3OpX/HukTlGGWCNxW/Pcz s5lIdZA764qEnNOJ1aUVWigwlEs0eL8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-iWRK9h61Pby-tN_PJLTkcA-1; Thu, 29 Oct 2020 15:42:47 -0400 X-MC-Unique: iWRK9h61Pby-tN_PJLTkcA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA6811868409; Thu, 29 Oct 2020 19:42:46 +0000 (UTC) Received: from [10.3.112.145] (ovpn-112-145.phx2.redhat.com [10.3.112.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBCBF196FB; Thu, 29 Oct 2020 19:42:38 +0000 (UTC) Subject: Re: [PATCH 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets To: Markus Armbruster , qemu-devel@nongnu.org References: <20201029133833.3450220-1-armbru@redhat.com> <20201029133833.3450220-11-armbru@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Thu, 29 Oct 2020 14:42:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201029133833.3450220-11-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 01:47:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.261, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berrange@redhat.com, zxq_yx_007@163.com, kraxel@redhat.com, pbonzini@redhat.com, marcandre.lureau@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/29/20 8:38 AM, Markus Armbruster wrote: > unix_listen_saddr() replaces empty @path by unique value. It obtains > the value by creating and deleting a unique temporary file with > mkstemp(). This is racy, as the comment explains. It's also entirely > undocumented as far as I can tell. Goes back to commit d247d25f18 > "sockets: helper functions for qemu (Gerd Hoffman)", v0.10.0. > > Since abstract socket addresses have no connection with filesystem > pathnames, making them up with mkstemp() seems inappropriate. Bypass > the replacement of empty @path. > > Signed-off-by: Markus Armbruster > --- > util/qemu-sockets.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Eric Blake > diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c > index 801c5e3957..18c8de8cdb 100644 > --- a/util/qemu-sockets.c > +++ b/util/qemu-sockets.c > @@ -871,7 +871,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr, > return -1; > } > > - if (saddr->path && saddr->path[0]) { > + if (saddr->path[0] || saddr->abstract) { > path = saddr->path; > } else { > const char *tmpdir = getenv("TMPDIR"); > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org