From: Richard Henderson <richard.henderson@linaro.org>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Cc: anton.kochkov@proton.me
Subject: Re: [PATCH v2 05/10] target/tricore: Fix RRPW_DEXTR
Date: Thu, 2 Feb 2023 05:52:14 -1000 [thread overview]
Message-ID: <a3275c10-2461-73f3-eaf4-3a21597c43bc@linaro.org> (raw)
In-Reply-To: <20230202120432.1268-6-kbastian@mail.uni-paderborn.de>
On 2/2/23 02:04, Bastian Koppelmann wrote:
> if we used const16 == 0 we would crash qemu with the error:
> ../tcg/tcg-op.c:196: tcg_gen_shri_i32: Assertion `arg2 >= 0 && arg2 < 32' failed
>
> This whole instruction can be handled by 'tcg_gen_extract2_tl' which
> takes care of this special case as well.
>
> Signed-off-by: Bastian Koppelmann<kbastian@mail.uni-paderborn.de>
> ---
> v1 -> v2:
> Use tcg_gen_extract2_tl and remove all special cases.
>
> target/tricore/translate.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-02-02 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 12:04 [PATCH v2 00/10] TriCore instruction bugfixes Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 01/10] target/tricore: Fix OPC2_32_RCRW_IMASK translation Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 02/10] tests/tcg/tricore: Add test for OPC2_32_RCRW_IMASK Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 03/10] target/tricore: Fix OPC2_32_RCRW_INSERT translation Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 04/10] tests/tcg/tricore: Add test for OPC2_32_RCRW_INSERT Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 05/10] target/tricore: Fix RRPW_DEXTR Bastian Koppelmann
2023-02-02 15:52 ` Richard Henderson [this message]
2023-02-02 12:04 ` [PATCH v2 06/10] tests/tcg/tricore: Add tests for RRPW_DEXTR Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 07/10] target/tricore: Fix OPC2_32_RRRR_DEXTR Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 08/10] tests/tcg/tricore: Add OPC2_32_RRRR_DEXTR tests Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 09/10] target/tricore: Fix OPC2_32_BO_LD_BU_PREINC Bastian Koppelmann
2023-02-02 12:04 ` [PATCH v2 10/10] tests/tcg/tricore: Add LD.BU tests Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3275c10-2461-73f3-eaf4-3a21597c43bc@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anton.kochkov@proton.me \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).