From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Klaus Jensen <its@irrelevant.dk>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Keith Busch <kbusch@kernel.org>,
Jinhao Fan <fanjinhao21s@ict.ac.cn>,
Guenter Roeck <linux@roeck-us.net>,
Klaus Jensen <k.jensen@samsung.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH v3 3/4] hw/nvme: fix missing endian conversions for doorbell buffers
Date: Mon, 12 Dec 2022 12:35:20 +0100 [thread overview]
Message-ID: <a32b241c-e46d-a422-ebe5-aee4b1cc5b0c@linaro.org> (raw)
In-Reply-To: <20221212113215.33135-4-its@irrelevant.dk>
On 12/12/22 12:32, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> The eventidx and doorbell value are not handling endianness correctly.
> Fix this.
>
> Fixes: 3f7fe8de3d49 ("hw/nvme: Implement shadow doorbell buffer support")
> Cc: qemu-stable@nongnu.org
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/nvme/ctrl.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2022-12-12 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 11:32 [PATCH v3 0/4] hw/nvme: fix broken shadow doorbells on some platforms Klaus Jensen
2022-12-12 11:32 ` [PATCH v3 1/4] hw/nvme: use QOM accessors Klaus Jensen
2022-12-12 11:32 ` [PATCH v3 2/4] hw/nvme: rename shadow doorbell related trace events Klaus Jensen
2022-12-12 11:32 ` [PATCH v3 3/4] hw/nvme: fix missing endian conversions for doorbell buffers Klaus Jensen
2022-12-12 11:35 ` Philippe Mathieu-Daudé [this message]
2022-12-12 11:32 ` [PATCH v3 4/4] hw/nvme: fix missing cq eventidx update Klaus Jensen
2022-12-12 11:37 ` Philippe Mathieu-Daudé
2022-12-12 11:39 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a32b241c-e46d-a422-ebe5-aee4b1cc5b0c@linaro.org \
--to=philmd@linaro.org \
--cc=fanjinhao21s@ict.ac.cn \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux@roeck-us.net \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).