From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH v4 6/7] tests/plugin/mem: add option to print memory accesses
Date: Thu, 4 Jul 2024 16:29:32 -0700 [thread overview]
Message-ID: <a33d67fd-878c-4f27-9994-05ff4a861064@linaro.org> (raw)
In-Reply-To: <1b23fba0-ab69-444f-8299-9db4f33373a9@linaro.org>
On 7/4/24 09:30, Richard Henderson wrote:
> On 7/2/24 11:44, Pierrick Bouvier wrote:
>> + case QEMU_PLUGIN_MEM_VALUE_U128:
>> + g_string_append_printf(out, "0x%.0"PRIx64"%"PRIx64,
>> + value.data.u128.high, value.data.u128.low);
>
> PRIx64 does not pad.
> You need %016"PRIx64 for the low value.
>
Oops, indeed. I'll output all values with fixed width.
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~
next prev parent reply other threads:[~2024-07-04 23:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 18:44 [PATCH v4 0/7] plugins: access values during a memory read/write Pierrick Bouvier
2024-07-02 18:44 ` [PATCH v4 1/7] plugins: fix mem callback array size Pierrick Bouvier
2024-07-03 18:39 ` Richard Henderson
2024-07-02 18:44 ` [PATCH v4 2/7] plugins: save value during memory accesses Pierrick Bouvier
2024-07-03 18:58 ` Richard Henderson
2024-07-05 0:33 ` Pierrick Bouvier
2024-07-02 18:44 ` [PATCH v4 3/7] plugins: extend API to get latest memory value accessed Pierrick Bouvier
2024-07-04 16:27 ` Richard Henderson
2024-07-02 18:44 ` [PATCH v4 4/7] tests/tcg: add mechanism to run specific tests with plugins Pierrick Bouvier
2024-07-03 2:26 ` Xingtao Yao (Fujitsu) via
2024-07-02 18:44 ` [PATCH v4 5/7] tests/tcg: allow to check output of plugins Pierrick Bouvier
2024-07-03 2:30 ` Xingtao Yao (Fujitsu) via
2024-07-04 16:28 ` Richard Henderson
2024-07-02 18:44 ` [PATCH v4 6/7] tests/plugin/mem: add option to print memory accesses Pierrick Bouvier
2024-07-03 1:56 ` Xingtao Yao (Fujitsu) via
2024-07-04 23:30 ` Pierrick Bouvier
2024-07-04 16:30 ` Richard Henderson
2024-07-04 23:29 ` Pierrick Bouvier [this message]
2024-07-02 18:44 ` [PATCH v4 7/7] tests/tcg/x86_64: add test for plugin memory access Pierrick Bouvier
2024-07-03 1:42 ` Xingtao Yao (Fujitsu) via
2024-07-05 0:42 ` [PATCH v4 0/7] plugins: access values during a memory read/write Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a33d67fd-878c-4f27-9994-05ff4a861064@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).