From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 408F9C18E7C for ; Wed, 26 Feb 2025 15:57:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tnJmR-00043I-Bv; Wed, 26 Feb 2025 10:57:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnJll-0003of-Fp for qemu-devel@nongnu.org; Wed, 26 Feb 2025 10:56:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnJlj-0004lB-CE for qemu-devel@nongnu.org; Wed, 26 Feb 2025 10:56:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740585377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0RzG/UYd4/VTByBYbmtsz+ZYpJ5Vz9qs2kCPeYQiubs=; b=NN6LI8s+fLa3fCTVlR+vphCRCEwqsEWbDatXoiSbVdz6yb+5Tgjjc7e9a7ztx9nESX3fvd 4adOx1xjCBP513Gd8QMc7ZqWtIMel6JSNTf7mu9vYO/lYlgYkbBX5exGmdSrBjQWGHES/f jRnT0UFh0zYmmq4vNAlYeCt7xIYYU9U= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-owx_PQ5xNhmbRVoKvV263Q-1; Wed, 26 Feb 2025 10:56:16 -0500 X-MC-Unique: owx_PQ5xNhmbRVoKvV263Q-1 X-Mimecast-MFC-AGG-ID: owx_PQ5xNhmbRVoKvV263Q_1740585375 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38f3eb82fceso2737102f8f.0 for ; Wed, 26 Feb 2025 07:56:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740585375; x=1741190175; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0RzG/UYd4/VTByBYbmtsz+ZYpJ5Vz9qs2kCPeYQiubs=; b=Xv1xWYovXQy2QLZAJV1y7KQjkkV120Dqt9npIbDEqhEsTBOSBN2+5fzfic2CdNSz/l tTjPsclthcHVnmHEf62iuj6lmjH7EPZM97tcrcg4RuAj3HD5Me10AazQECGQfOnNGiDu wGTMhEgVUkMFeqdFN+Au69kYFjTZs0JrGPUyJbeBN1goG0sE4cnFdEVckimWbWHBZ2V/ rypH2rE4iyj5pEqetoi1aloCNdXc1mli3B2LGBnUrRycxH+xjzlPVN8/m9ytZwQm2LsL dx3JlxXU4CWmHdRZhQjp2P2MsTLeSBsEyUOzt2tFLQi2uwsFtQJAy31hZpNuPhdMFpu3 +rhQ== X-Forwarded-Encrypted: i=1; AJvYcCUsOKStTG3JeSuVKf46FnsFb2c/aBHpOqAN/9SHPfUECx+jkV++JWPClooyCWsDn4F4svxvUFKq6aio@nongnu.org X-Gm-Message-State: AOJu0YzWz4Iq2fTuxGzS4qLjD77tUv8BzahuvhGzj+VcZVdnSMpq8EDi IThWFvuccrDaF9/o2ecfsfXFNVVC2jMzyLe/puD/wlab4CHioKHLQ3Uriep/rKu9edAGWBCIbkw TNgITXsVYzKobuFbTnsJrm2CZZ8SYPEZ6PhkUCHlWs9tJnlXQgAKu X-Gm-Gg: ASbGnct+Wb3a2w1pY2OObb7ej1f9yLjPRYtv7YUbZnjpeJaUMvTl/MEOFahSqbHIGXq IIyAYIMrMs+16zMJZUSZnLyCvP+GO6Eh22ckoebVRzptbLH4xqaYig+sV2g/UcN+0dxFVJ4fk3E GTOyOaPRXL96AjFXCVAhh5LCj4iAXungRJ04FmuKJM0Ipvm8yWCDZiaXGLRUIudzUg9BonxbYTw Okr+8M/yy8bnwCtSPPbX8ec+iHm/CeZnAhOXuNH8DravzNboZfSKdtBiaN1KR3GxMJ0e/6hZPs4 qP0bAsMSScG6J8ggyeWWVSHi8IIY0p6LueIHxCdpf0A/RJzcV69cGuMO07s= X-Received: by 2002:adf:fa41:0:b0:38f:2bee:e13c with SMTP id ffacd0b85a97d-390cc638bc7mr5562000f8f.53.1740585375221; Wed, 26 Feb 2025 07:56:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IGubEGXsfKhTGmoBFCH5fnTMKZyjzP2OP9QpiDjZLb9L5X1qBD8Uc5VnOiUS07phF9f837uPA== X-Received: by 2002:adf:fa41:0:b0:38f:2bee:e13c with SMTP id ffacd0b85a97d-390cc638bc7mr5561982f8f.53.1740585374815; Wed, 26 Feb 2025 07:56:14 -0800 (PST) Received: from ?IPV6:2a01:cb19:9004:d500:a732:5611:7f59:8bb3? ([2a01:cb19:9004:d500:a732:5611:7f59:8bb3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e00fef78sm426099f8f.98.2025.02.26.07.56.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 07:56:14 -0800 (PST) Message-ID: Date: Wed, 26 Feb 2025 16:56:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 19/36] vfio/migration: Convert bytes_transferred counter to atomic To: "Maciej S. Szmigiero" Cc: Alex Williamson , Peter Xu , Fabiano Rosas , Eric Blake , Markus Armbruster , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Avihai Horon , Joao Martins , qemu-devel@nongnu.org References: Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.44, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/26/25 14:55, Maciej S. Szmigiero wrote: > On 26.02.2025 08:52, Cédric Le Goater wrote: >> On 2/19/25 21:34, Maciej S. Szmigiero wrote: >>> From: "Maciej S. Szmigiero" >>> >>> So it can be safety accessed from multiple threads. >>> >>> This variable type needs to be changed to unsigned long since >>> 32-bit host platforms lack the necessary addition atomics on 64-bit >>> variables. >>> >>> Using 32-bit counters on 32-bit host platforms should not be a problem >>> in practice since they can't realistically address more memory anyway. >> >> Is it useful to have VFIO on 32-bit host platforms ? >> >> If not, VFIO PCI should depend on (AARCH64 || PPC64 || X86_64) and we >> could drop this patch. Let's address that independently. > > Not sure how much use VFIO gets on 32-bit host platforms, > however totally disabling it on these would be a major functional regression - > at least if taken at its face value. 32-bit host platform support is being deprecated in QEMU 10.0 and should be removed in QEMU 10.2. > Especially considering that making it work on 32-bit platform requires > just this tiny variable type change here. yes. It raised my attention because x86 32-bit was the only host platform I was not sure about and Alex confirmed it worked. We should simply wait for removal. Thanks, C.