Re: [Qemu-devel] [RFC PATCH 02/32] texi2pod: Support @verbatim environment

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]

On 10/06/2017 12:24 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
> 
>> On 10/02/2017 10:25 AM, Markus Armbruster wrote:
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>>>  scripts/texi2pod.pl | 11 +++++++++--
>>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>

>>> +	and not (/^\@end\s+([a-z]+)/ and $1 eq $endw)) {
>>
>> You anchored to the beginning, but not the end, of the line; that means
>> you accept '@end verbatim garbage' as an end marker.  Worth adding $?
> 
> Cribbed from
> 
>     # End-block handler goes up here because it needs to operate even
>     # if we are skipping.
>     /^\@end\s+([a-z]+)/ and do {
> 	# Ignore @end foo, where foo is not an operation which may
> 	# cause us to skip, if we are presently skipping.
> 	my $ended = $1;
> 	next if $skipping && $ended !~ /^(?:ifset|ifclear|ignore|menu|iftex|copying)$/;
> 
> 	die "\@end $ended without \@$ended at line $.\n" unless defined $endw;
> 	die "\@$endw ended by \@end $ended at line $.\n" unless $ended eq $endw;
> 
> 	$endw = pop @endwstack;
> 
> I'd prefer to stick to this regexp.

Consistency makes sense.

> 
> texi2pod.pl parses quite sloppily in general.
> 
>> If that's the only change, I'm okay with adding:
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Does this apply to the unchanged patch, too?

Yes.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]