qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Thomas Huth" <thuth@redhat.com>,
	qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH 4/6] tests/functional: Fix problems in testcase.py reported by pylint
Date: Wed, 22 Oct 2025 21:10:03 +0200	[thread overview]
Message-ID: <a3413bbd-e98c-4267-81c7-aa42aeda8a09@linaro.org> (raw)
In-Reply-To: <20251015095454.1575318-5-thuth@redhat.com>

On 15/10/25 11:54, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> - put 3rd party "import pycotap" after the standard imports
> - "help" is a built-in function in Python, don't use it as a variable name
> - put the doc strings in the right locations (after the "def" line)
> - use isinstance() instead of checking via type()
> - use lazy logging strings
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/qemu_test/testcase.py | 251 +++++++++++++------------
>   1 file changed, 126 insertions(+), 125 deletions(-)


> -    def run_cmd(self, bin_path, args=[]):
> +    def run_cmd(self, bin_path, args=None):
> +        if args is None:
> +            args = []

For my own education, what is the issue reported here?

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2025-10-22 19:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  9:54 [PATCH 0/6] tests/functional: Fix various problems reported by pylint Thomas Huth
2025-10-15  9:54 ` [PATCH 1/6] tests/functional: Fix problems in asset.py " Thomas Huth
2025-10-15  9:54 ` [PATCH 2/6] tests/functional: Fix problems in decorators.py " Thomas Huth
2025-10-22 19:15   ` Philippe Mathieu-Daudé
2025-10-15  9:54 ` [PATCH 3/6] tests/functional: Fix problems in linuxkerenl.py " Thomas Huth
2025-10-22 19:14   ` Philippe Mathieu-Daudé
2025-10-23  6:46     ` Thomas Huth
2025-10-23 15:13       ` John Snow
2025-10-15  9:54 ` [PATCH 4/6] tests/functional: Fix problems in testcase.py " Thomas Huth
2025-10-22 19:10   ` Philippe Mathieu-Daudé [this message]
2025-10-23  4:57     ` Thomas Huth
2025-10-15  9:54 ` [PATCH 5/6] tests/functional: Fix problems in uncompress.py " Thomas Huth
2025-10-22 19:07   ` Philippe Mathieu-Daudé
2025-10-15  9:54 ` [PATCH 6/6] tests/functional: Fix problems in utils.py " Thomas Huth
2025-10-22 19:07   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3413bbd-e98c-4267-81c7-aa42aeda8a09@linaro.org \
    --to=philmd@linaro.org \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).