From: Farhan Ali <alifm@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org,
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Cc: Collin Walling <walling@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 0/4] pc-bios/s390-ccw: Network boot improvements
Date: Thu, 19 Apr 2018 08:03:37 -0400 [thread overview]
Message-ID: <a3471bd4-85ff-3677-3cfe-136beefb180d@linux.ibm.com> (raw)
In-Reply-To: <842dc876-dd3e-18d9-bfff-128b357b6281@redhat.com>
On 04/19/2018 01:27 AM, Thomas Huth wrote:
> Ah, that's not a memory leak, though it might look like one if you don't
> know what the vring_send_buf function is doing: vring_send_buf adds a
> buffer to a virtio ring for later use. So the buffer is not unused after
> this function, but gets filled in later by the virtio-net device. Thus
> we must not free the buffer here.
>
> We could free it in the "uninit" function after shutting down the
> device, but OTOH we are then leaving the firmware code anyway by jumping
> into the OS kernel, so it does not really matter whether we free()ed the
> buffers or not.
>
> Thomas
That makes a lot of sense now :) thanks a lot for that explanation and
sorry for my ignorance.
prev parent reply other threads:[~2018-04-19 12:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 12:31 [Qemu-devel] [PATCH v1 for-2.13 0/4] pc-bios/s390-ccw: Network boot improvements Thomas Huth
2018-04-18 12:31 ` [Qemu-devel] [PATCH v1 for-2.13 1/4] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts Thomas Huth
2018-04-18 18:11 ` Farhan Ali
2018-04-19 5:20 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-04-18 12:31 ` [Qemu-devel] [PATCH v1 for-2.13 2/4] pc-bios/s390-ccw/net: Stop virtio-net device before jumping into the OS Thomas Huth
2018-04-19 15:49 ` Christian Borntraeger
2018-04-20 6:31 ` Thomas Huth
2018-04-20 7:25 ` Christian Borntraeger
2018-04-18 12:31 ` [Qemu-devel] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files Thomas Huth
2018-04-19 7:41 ` Viktor VM Mihajlovski
2018-04-19 8:17 ` Thomas Huth
2018-04-19 12:40 ` Viktor VM Mihajlovski
2018-04-19 16:55 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-04-20 6:53 ` Viktor VM Mihajlovski
2018-04-20 7:36 ` Thomas Huth
2018-04-20 7:54 ` Viktor VM Mihajlovski
2018-04-20 8:40 ` Thomas Huth
2018-04-20 12:11 ` Viktor VM Mihajlovski
2018-04-18 12:31 ` [Qemu-devel] [PATCH v1 for-2.13 4/4] pc-bios/s390-ccw/net: Add support for .INS " Thomas Huth
2018-04-19 8:02 ` Viktor VM Mihajlovski
2018-04-19 8:20 ` Thomas Huth
2018-04-18 18:21 ` [Qemu-devel] [PATCH v1 for-2.13 0/4] pc-bios/s390-ccw: Network boot improvements Farhan Ali
2018-04-19 5:27 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-04-19 12:03 ` Farhan Ali [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3471bd4-85ff-3677-3cfe-136beefb180d@linux.ibm.com \
--to=alifm@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).