From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, zhang.zhanghailiang@huawei.com,
qemu-block@nongnu.org, quintela@redhat.com, armbru@redhat.com,
dgilbert@redhat.com, mreitz@redhat.com, den@openvz.org,
marcandre.lureau@redhat.com, mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH 2/6] block/mirror: fix use after free of local_err
Date: Tue, 24 Mar 2020 13:10:40 -0400 [thread overview]
Message-ID: <a34a7f16-cca9-c551-af78-53b673aea0cf@redhat.com> (raw)
In-Reply-To: <20200324153630.11882-3-vsementsov@virtuozzo.com>
On 3/24/20 11:36 AM, Vladimir Sementsov-Ogievskiy wrote:
> local_err is used again in mirror_exit_common() after
> bdrv_set_backing_hd(), so we must zero it. Otherwise try to set
> non-NULL local_err will crash.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/mirror.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 447051dbc6..6203e5946e 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -678,6 +678,7 @@ static int mirror_exit_common(Job *job)
> bdrv_set_backing_hd(target_bs, backing, &local_err);
> if (local_err) {
> error_report_err(local_err);
> + local_err = NULL;
> ret = -EPERM;
> }
> }
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2020-03-24 17:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 15:36 [PATCH for-5.0 0/6] Several error use-after-free Vladimir Sementsov-Ogievskiy
2020-03-24 15:36 ` [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci Vladimir Sementsov-Ogievskiy
2020-03-31 9:00 ` Markus Armbruster
2020-03-31 9:12 ` Vladimir Sementsov-Ogievskiy
2020-03-31 13:14 ` Markus Armbruster
2020-03-31 13:49 ` Vladimir Sementsov-Ogievskiy
2020-03-31 18:38 ` Markus Armbruster
2020-03-31 18:56 ` Peter Maydell
2020-04-01 5:07 ` Markus Armbruster
2020-04-01 11:04 ` Peter Maydell
2020-04-01 14:44 ` Markus Armbruster
2020-04-01 16:12 ` Peter Maydell
2020-04-02 6:55 ` Markus Armbruster
2020-04-02 8:19 ` Peter Maydell
2020-04-02 8:36 ` Markus Armbruster
2020-03-24 15:36 ` [PATCH 2/6] block/mirror: fix use after free of local_err Vladimir Sementsov-Ogievskiy
2020-03-24 15:57 ` Eric Blake
2020-03-24 17:10 ` John Snow [this message]
2020-03-25 11:11 ` Max Reitz
2020-03-25 11:29 ` Max Reitz
2020-03-25 11:47 ` Vladimir Sementsov-Ogievskiy
2020-03-25 12:00 ` Max Reitz
2020-03-31 9:12 ` Markus Armbruster
2020-03-25 13:01 ` Eric Blake
2020-03-25 12:01 ` Max Reitz
2020-03-24 15:36 ` [PATCH 3/6] dump/win_dump: fix use after free of err Vladimir Sementsov-Ogievskiy
2020-03-30 15:54 ` Markus Armbruster
2020-03-24 15:36 ` [PATCH 4/6] migration/colo: fix use after free of local_err Vladimir Sementsov-Ogievskiy
2020-03-24 19:40 ` Dr. David Alan Gilbert
2020-03-24 15:36 ` [PATCH 5/6] migration/ram: " Vladimir Sementsov-Ogievskiy
2020-03-24 19:41 ` Dr. David Alan Gilbert
2020-03-24 15:36 ` [PATCH 6/6] qga/commands-posix: " Vladimir Sementsov-Ogievskiy
2020-03-24 20:03 ` Eric Blake
2020-03-25 4:28 ` Vladimir Sementsov-Ogievskiy
2020-03-31 11:46 ` Markus Armbruster
2020-03-31 12:04 ` Vladimir Sementsov-Ogievskiy
2020-03-31 8:13 ` Markus Armbruster
2020-03-24 15:50 ` [PATCH for-5.0 0/6] Several error use-after-free Richard Henderson
2020-04-04 12:18 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a34a7f16-cca9-c551-af78-53b673aea0cf@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).