From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnBFX-0000hc-On for qemu-devel@nongnu.org; Thu, 22 Sep 2016 17:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnBFR-0000eV-NR for qemu-devel@nongnu.org; Thu, 22 Sep 2016 17:09:42 -0400 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:34588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnBFR-0000e2-JN for qemu-devel@nongnu.org; Thu, 22 Sep 2016 17:09:37 -0400 Received: by mail-qk0-x22a.google.com with SMTP id n185so89022483qke.1 for ; Thu, 22 Sep 2016 14:09:37 -0700 (PDT) Sender: Richard Henderson References: <1473945360-13663-1-git-send-email-pbonzini@redhat.com> From: Richard Henderson Message-ID: Date: Thu, 22 Sep 2016 14:09:34 -0700 MIME-Version: 1.0 In-Reply-To: <1473945360-13663-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg: try sti when moving a constant into a dead memory temp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 09/15/2016 06:16 AM, Paolo Bonzini wrote: > This comes from free from unifying tcg_reg_alloc_mov and > tcg_reg_alloc_movi's handling of TEMP_VAL_CONST. It triggers > often on moves to cc_dst, such as the following translation > of "sub $0x3c,%esp": > > before: after: > subl $0x3c,%ebp subl $0x3c,%ebp > movl %ebp,0x10(%r14) movl %ebp,0x10(%r14) > movl $0x3c,%ebx movl $0x3c,0x2c(%r14) > movl %ebx,0x2c(%r14) > > Signed-off-by: Paolo Bonzini > --- > tcg/tcg.c | 56 +++++++++++++++++++++++++++----------------------------- > 1 file changed, 27 insertions(+), 29 deletions(-) Queued. Thanks, r~