qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
To: "faithilikerun@gmail.com" <faithilikerun@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "hreitz@redhat.com" <hreitz@redhat.com>,
	"hare@suse.de" <hare@suse.de>,
	"philmd@linaro.org" <philmd@linaro.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"fam@euphon.net" <fam@euphon.net>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
	"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
	"kwolf@redhat.com" <kwolf@redhat.com>,
	"thuth@redhat.com" <thuth@redhat.com>,
	 "pbonzini@redhat.com" <pbonzini@redhat.com>,
	"berrange@redhat.com" <berrange@redhat.com>,
	"damien.lemoal@opensource.wdc.com"
	<damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v16 1/8] include: add zoned device structs
Date: Mon, 13 Mar 2023 23:38:09 +0000	[thread overview]
Message-ID: <a35a2229c8453235ce12f71a8e6bf13a90e00c90.camel@wdc.com> (raw)
In-Reply-To: <20230310102403.61347-2-faithilikerun@gmail.com>

On Fri, 2023-03-10 at 18:23 +0800, Sam Li wrote:
> Signed-off-by: Sam Li <faithilikerun@gmail.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>

Looks good to me.

Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>

> ---
>  include/block/block-common.h | 43 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/include/block/block-common.h b/include/block/block-common.h
> index b5122ef8ab..1576fcf2ed 100644
> --- a/include/block/block-common.h
> +++ b/include/block/block-common.h
> @@ -75,6 +75,49 @@ typedef struct BlockDriver BlockDriver;
>  typedef struct BdrvChild BdrvChild;
>  typedef struct BdrvChildClass BdrvChildClass;
>  
> +typedef enum BlockZoneOp {
> +    BLK_ZO_OPEN,
> +    BLK_ZO_CLOSE,
> +    BLK_ZO_FINISH,
> +    BLK_ZO_RESET,
> +} BlockZoneOp;
> +
> +typedef enum BlockZoneModel {
> +    BLK_Z_NONE = 0x0, /* Regular block device */
> +    BLK_Z_HM = 0x1, /* Host-managed zoned block device */
> +    BLK_Z_HA = 0x2, /* Host-aware zoned block device */
> +} BlockZoneModel;
> +
> +typedef enum BlockZoneState {
> +    BLK_ZS_NOT_WP = 0x0,
> +    BLK_ZS_EMPTY = 0x1,
> +    BLK_ZS_IOPEN = 0x2,
> +    BLK_ZS_EOPEN = 0x3,
> +    BLK_ZS_CLOSED = 0x4,
> +    BLK_ZS_RDONLY = 0xD,
> +    BLK_ZS_FULL = 0xE,
> +    BLK_ZS_OFFLINE = 0xF,
> +} BlockZoneState;
> +
> +typedef enum BlockZoneType {
> +    BLK_ZT_CONV = 0x1, /* Conventional random writes supported */
> +    BLK_ZT_SWR = 0x2, /* Sequential writes required */
> +    BLK_ZT_SWP = 0x3, /* Sequential writes preferred */
> +} BlockZoneType;
> +
> +/*
> + * Zone descriptor data structure.
> + * Provides information on a zone with all position and size values in bytes.
> + */
> +typedef struct BlockZoneDescriptor {
> +    uint64_t start;
> +    uint64_t length;
> +    uint64_t cap;
> +    uint64_t wp;
> +    BlockZoneType type;
> +    BlockZoneState state;
> +} BlockZoneDescriptor;
> +
>  typedef struct BlockDriverInfo {
>      /* in bytes, 0 if irrelevant */
>      int cluster_size;


  reply	other threads:[~2023-03-13 23:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 10:23 [PATCH v16 0/8] Add support for zoned device Sam Li
2023-03-10 10:23 ` [PATCH v16 1/8] include: add zoned device structs Sam Li
2023-03-13 23:38   ` Dmitry Fomichev [this message]
2023-03-10 10:23 ` [PATCH v16 2/8] file-posix: introduce helper functions for sysfs attributes Sam Li
2023-03-10 10:23 ` [PATCH v16 3/8] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls Sam Li
2023-03-13 23:39   ` Dmitry Fomichev
2023-03-10 10:23 ` [PATCH v16 4/8] raw-format: add zone operations to pass through requests Sam Li
2023-03-10 10:24 ` [PATCH v16 5/8] config: add check to block layer Sam Li
2023-03-10 10:24 ` [PATCH v16 6/8] qemu-iotests: test new zone operations Sam Li
2023-03-10 10:24 ` [PATCH v16 7/8] block: add some trace events for new block layer APIs Sam Li
2023-03-13 23:40   ` Dmitry Fomichev
2023-03-10 10:24 ` [PATCH v16 8/8] docs/zoned-storage: add zoned device documentation Sam Li
2023-03-16 17:57 ` [PATCH v16 0/8] Add support for zoned device Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a35a2229c8453235ce12f71a8e6bf13a90e00c90.camel@wdc.com \
    --to=dmitry.fomichev@wdc.com \
    --cc=berrange@redhat.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=faithilikerun@gmail.com \
    --cc=fam@euphon.net \
    --cc=hare@suse.de \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).