From: Claudio Fontana <cfontana@suse.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
qemu-devel@nongnu.org
Subject: Re: [RFC] accel: add cpu_reset
Date: Mon, 22 Mar 2021 14:54:59 +0100 [thread overview]
Message-ID: <a387d69e-f202-d4e4-476e-9452072fd238@suse.de> (raw)
In-Reply-To: <e7e0cfe6-d9c8-8cd4-39bc-65374771824a@amsat.org>
On 3/22/21 2:42 PM, Philippe Mathieu-Daudé wrote:
> On 3/22/21 2:27 PM, Claudio Fontana wrote:
>> XXX
>> ---
>> accel/accel-common.c | 9 +++++++++
>> hw/core/cpu.c | 3 ++-
>> include/hw/core/accel-cpu.h | 2 ++
>> include/qemu/accel.h | 6 ++++++
>> target/i386/cpu.c | 4 ----
>> target/i386/kvm/kvm-cpu.c | 6 ++++++
>> 6 files changed, 25 insertions(+), 5 deletions(-)
>>
>>
>> This surprisingly works without moving cpu_reset() to a
>> specific_ss module, even though
>>
>> accel-common.c is specific_ss,
>> hw/core/cpu.c is common_ss.
>>
>> How come the call to accel_reset_cpu works?
>
> Each CPU optionally calls cpu_reset() manually?
Hi Philippe, are you concerned about these calls?
Or what are you highlighting here?
They in turn call cpu_reset() so we should be good right?
Ciao,
Claudio
>
> $ git grep register_reset.*cpu
> hw/arm/armv7m.c:334: qemu_register_reset(armv7m_reset, cpu);
> hw/arm/boot.c:1290: qemu_register_reset(do_cpu_reset, ARM_CPU(cs));
> hw/cris/boot.c:101: qemu_register_reset(main_cpu_reset, cpu);
> hw/lm32/lm32_boards.c:162: qemu_register_reset(main_cpu_reset,
> reset_info);
> hw/lm32/lm32_boards.c:289: qemu_register_reset(main_cpu_reset,
> reset_info);
> hw/lm32/milkymist.c:238: qemu_register_reset(main_cpu_reset, reset_info);
> hw/m68k/q800.c:247: qemu_register_reset(main_cpu_reset, cpu);
> hw/m68k/virt.c:132: qemu_register_reset(main_cpu_reset, cpu);
> hw/microblaze/boot.c:134: qemu_register_reset(main_cpu_reset, cpu);
> hw/mips/cps.c:107: qemu_register_reset(main_cpu_reset, cpu);
> hw/mips/fuloong2e.c:269: qemu_register_reset(main_cpu_reset, cpu);
> hw/mips/jazz.c:195: qemu_register_reset(main_cpu_reset, cpu);
> hw/mips/loongson3_virt.c:545: qemu_register_reset(main_cpu_reset,
> cpu);
> hw/mips/malta.c:1185: qemu_register_reset(main_cpu_reset, cpu);
> hw/mips/mipssim.c:170: qemu_register_reset(main_cpu_reset, reset_info);
> hw/moxie/moxiesim.c:120: qemu_register_reset(main_cpu_reset, cpu);
> hw/nios2/boot.c:138: qemu_register_reset(main_cpu_reset, cpu);
> hw/openrisc/openrisc_sim.c:160:
> qemu_register_reset(main_cpu_reset, cpus[n]);
> hw/ppc/e500.c:903: qemu_register_reset(ppce500_cpu_reset, cpu);
> hw/ppc/e500.c:907: qemu_register_reset(ppce500_cpu_reset_sec,
> cpu);
> hw/ppc/mac_newworld.c:156: qemu_register_reset(ppc_core99_reset,
> cpu);
> hw/ppc/mac_oldworld.c:118:
> qemu_register_reset(ppc_heathrow_reset, cpu);
> hw/ppc/ppc440_bamboo.c:192: qemu_register_reset(main_cpu_reset, cpu);
> hw/ppc/ppc4xx_devs.c:75: qemu_register_reset(ppc4xx_reset, cpu);
> hw/ppc/ppc_booke.c:369:
> qemu_register_reset(ppc_booke_timer_reset_handle, cpu);
> hw/ppc/prep.c:270: qemu_register_reset(ppc_prep_reset, cpu);
> hw/ppc/sam460ex.c:306: qemu_register_reset(main_cpu_reset, cpu);
> hw/ppc/spapr_cpu_core.c:245:
> qemu_unregister_reset(spapr_cpu_core_reset_handler, sc);
> hw/ppc/spapr_cpu_core.c:326:
> qemu_register_reset(spapr_cpu_core_reset_handler, sc);
> hw/ppc/virtex_ml507.c:233: qemu_register_reset(main_cpu_reset, cpu);
> hw/riscv/riscv_hart.c:51: qemu_register_reset(riscv_harts_cpu_reset,
> &s->harts[idx]);
> hw/sh4/r2d.c:251: qemu_register_reset(main_cpu_reset, reset_info);
> hw/sparc/leon3.c:213: qemu_register_reset(main_cpu_reset, reset_info);
> hw/sparc/sun4m.c:828: qemu_register_reset(sun4m_cpu_reset, cpu);
> hw/sparc64/sparc64.c:357: qemu_register_reset(main_cpu_reset,
> reset_info);
> hw/xtensa/sim.c:68: qemu_register_reset(sim_reset, cpu);
> hw/xtensa/xtfpga.c:270: qemu_register_reset(xtfpga_reset, cpu);
> target/i386/cpu.c:6859: qemu_register_reset(x86_cpu_machine_reset_cb,
> cpu);
> target/i386/cpu.c:6942:
> qemu_unregister_reset(x86_cpu_machine_reset_cb, dev);
> target/i386/hax/hax-all.c:230:
> qemu_register_reset(hax_reset_vcpu_state, (CPUArchState *) (cpu->env_ptr));
> target/s390x/cpu.c:232:
> qemu_register_reset(s390_cpu_machine_reset_cb, cpu);
> target/s390x/cpu.c:319:
> qemu_unregister_reset(s390_cpu_machine_reset_cb, cpu);
>
next prev parent reply other threads:[~2021-03-22 14:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 13:27 [PATCH v28 00/23] i386 cleanup PART 2 Claudio Fontana
2021-03-22 13:27 ` [RFC] accel: add cpu_reset Claudio Fontana
2021-03-22 13:31 ` Paolo Bonzini
2021-03-22 13:35 ` Claudio Fontana
2021-03-22 13:45 ` Paolo Bonzini
2021-03-22 13:51 ` Claudio Fontana
2021-03-23 7:55 ` Paolo Bonzini
2021-03-22 13:42 ` Philippe Mathieu-Daudé
2021-03-22 13:54 ` Claudio Fontana [this message]
2021-03-23 8:43 ` Philippe Mathieu-Daudé
2021-03-22 13:27 ` [PATCH v28 01/23] target/i386: Rename helper_fldt, helper_fstt Claudio Fontana
2021-03-22 15:58 ` Alex Bennée
2021-03-22 13:27 ` [PATCH v28 02/23] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor Claudio Fontana
2021-03-22 16:14 ` Alex Bennée
2021-03-22 13:27 ` [PATCH v28 03/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 04/23] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 05/23] accel: introduce new accessor functions Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 06/23] target/i386: fix host_cpu_adjust_phys_bits error handling Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 07/23] accel-cpu: make cpu_realizefn return a bool Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 08/23] meson: add target_user_arch Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 09/23] i386: split off sysemu-only functionality in tcg-cpu Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 10/23] i386: split smm helper (sysemu) Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 11/23] i386: split tcg excp_helper into sysemu and user parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 12/23] i386: move TCG bpt_helper into sysemu/ Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 13/23] i386: split misc helper user stubs and sysemu part Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 14/23] i386: separate fpu_helper sysemu-only parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 15/23] i386: split svm_helper into sysemu and stub-only user Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 16/23] i386: split seg_helper into user-only and sysemu parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 17/23] i386: split off sysemu part of cpu.c Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 18/23] target/i386: gdbstub: introduce aux functions to read/write CS64 regs Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 19/23] target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 20/23] i386: make cpu_load_efer sysemu-only Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 21/23] accel: move call to accel_init_interfaces Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 22/23] accel: add init_accel_cpu for adapting accel behavior to CPU type Claudio Fontana
2021-03-22 13:28 ` [RFC v28 23/23] XXX RFC accel: add cpu_reset Claudio Fontana
2021-03-22 16:41 ` [PATCH v28 00/23] i386 cleanup PART 2 Paolo Bonzini
2021-04-08 13:38 ` Philippe Mathieu-Daudé
-- strict thread matches above, loose matches on Subject: below --
2021-03-19 12:32 [RFC] accel: add cpu_reset Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a387d69e-f202-d4e4-476e-9452072fd238@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).