From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N1XEM-0000Xy-Qe for qemu-devel@nongnu.org; Fri, 23 Oct 2009 23:23:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N1XEI-0000T6-A6 for qemu-devel@nongnu.org; Fri, 23 Oct 2009 23:23:50 -0400 Received: from [199.232.76.173] (port=39714 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1XEI-0000Sq-4c for qemu-devel@nongnu.org; Fri, 23 Oct 2009 23:23:46 -0400 Received: from mail-pz0-f188.google.com ([209.85.222.188]:54846) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N1XEH-0001J9-Q9 for qemu-devel@nongnu.org; Fri, 23 Oct 2009 23:23:45 -0400 Received: by pzk26 with SMTP id 26so6552940pzk.4 for ; Fri, 23 Oct 2009 20:23:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4AE1FCBD.8030904@mail.berlios.de> References: <4AE1FCBD.8030904@mail.berlios.de> Date: Sat, 24 Oct 2009 11:23:43 +0800 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH] tcg, tci: Add TCG and interpreter for bytecode (virtual machine) From: TeLeMan Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On Sat, Oct 24, 2009 at 02:58, Stefan Weil wrote: > Is patch 4 (call handling) needed, or is it an optimization? > If it is needed, the tcg disassembler has to be extended as well. In fact tci has no stack and robber registers and doesn't need simulate the CPU work. I am trying to remove tcg_reg_alloc() in tcg_reg_alloc_op() & tcg_reg_alloc_call() and access the temporary variables directly in tci. > And did patch 5 (inline) speed up the code? I had expected > that static functions don't need inline, because the compiler > can optimize them anyway. You are right, patch 5 is not needed.