* [Qemu-devel] [PATCH] target-i386: fix commit c22549204a6edc431e8e4358e61bd56386ff6957
@ 2010-03-12 11:38 TeLeMan
2010-03-12 13:22 ` [Qemu-devel] " Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: TeLeMan @ 2010-03-12 11:38 UTC (permalink / raw)
To: qemu-devel
The commit c22549204a6edc431e8e4358e61bd56386ff6957 led movntps &
movntdq to be translated incorrectly.
Signed-off-by: TeLeMan <geleman@gmail.com>
---
target-i386/translate.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 6838d53..07b0a70 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -3457,6 +3457,11 @@ static void gen_sse(DisasContext *s, int b,
target_ulong pc_start, int rex_r)
case 0x1e7: /* movntdq */
case 0x02b: /* movntps */
case 0x12b: /* movntps */
+ if (mod == 3)
+ goto illegal_op;
+ gen_lea_modrm(s, modrm, ®_addr, &offset_addr);
+ gen_sto_env_A0(s->mem_index, offsetof(CPUX86State,xmm_regs[reg]));
+ break;
case 0x3f0: /* lddqu */
if (mod == 3)
goto illegal_op;
--
1.6.5.1.1367.gcd48
--
SUN OF A BEACH
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] target-i386: fix commit c22549204a6edc431e8e4358e61bd56386ff6957
2010-03-12 11:38 [Qemu-devel] [PATCH] target-i386: fix commit c22549204a6edc431e8e4358e61bd56386ff6957 TeLeMan
@ 2010-03-12 13:22 ` Paolo Bonzini
2010-03-12 13:32 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2010-03-12 13:22 UTC (permalink / raw)
To: TeLeMan; +Cc: qemu-devel, Aurelien Jarno
On 03/12/2010 12:38 PM, TeLeMan wrote:
> The commit c22549204a6edc431e8e4358e61bd56386ff6957 led movntps&
> movntdq to be translated incorrectly.
This should go on stable-0.12 too.
Paolo
> Signed-off-by: TeLeMan<geleman@gmail.com>
> ---
> target-i386/translate.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index 6838d53..07b0a70 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -3457,6 +3457,11 @@ static void gen_sse(DisasContext *s, int b,
> target_ulong pc_start, int rex_r)
> case 0x1e7: /* movntdq */
> case 0x02b: /* movntps */
> case 0x12b: /* movntps */
> + if (mod == 3)
> + goto illegal_op;
> + gen_lea_modrm(s, modrm,®_addr,&offset_addr);
> + gen_sto_env_A0(s->mem_index, offsetof(CPUX86State,xmm_regs[reg]));
> + break;
> case 0x3f0: /* lddqu */
> if (mod == 3)
> goto illegal_op;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] target-i386: fix commit c22549204a6edc431e8e4358e61bd56386ff6957
2010-03-12 13:22 ` [Qemu-devel] " Paolo Bonzini
@ 2010-03-12 13:32 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2010-03-12 13:32 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: TeLeMan, qemu-devel
Paolo Bonzini a écrit :
> On 03/12/2010 12:38 PM, TeLeMan wrote:
>> The commit c22549204a6edc431e8e4358e61bd56386ff6957 led movntps&
>> movntdq to be translated incorrectly.
>
> This should go on stable-0.12 too.
>
The patch is correct, and I agree it should go to stable-0.12 too. I'll
commit it later today.
>
>> Signed-off-by: TeLeMan<geleman@gmail.com>
>> ---
>> target-i386/translate.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-i386/translate.c b/target-i386/translate.c
>> index 6838d53..07b0a70 100644
>> --- a/target-i386/translate.c
>> +++ b/target-i386/translate.c
>> @@ -3457,6 +3457,11 @@ static void gen_sse(DisasContext *s, int b,
>> target_ulong pc_start, int rex_r)
>> case 0x1e7: /* movntdq */
>> case 0x02b: /* movntps */
>> case 0x12b: /* movntps */
>> + if (mod == 3)
>> + goto illegal_op;
>> + gen_lea_modrm(s, modrm,®_addr,&offset_addr);
>> + gen_sto_env_A0(s->mem_index, offsetof(CPUX86State,xmm_regs[reg]));
>> + break;
>> case 0x3f0: /* lddqu */
>> if (mod == 3)
>> goto illegal_op;
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-12 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-12 11:38 [Qemu-devel] [PATCH] target-i386: fix commit c22549204a6edc431e8e4358e61bd56386ff6957 TeLeMan
2010-03-12 13:22 ` [Qemu-devel] " Paolo Bonzini
2010-03-12 13:32 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).