From: gaosong <gaosong@loongson.cn>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, peter.maydell@linaro.org,
maobibo@loongson.cn
Subject: Re: [PATCH v3 04/17] hw/loongarch: Add init_cmdline
Date: Thu, 28 Dec 2023 09:06:28 +0800 [thread overview]
Message-ID: <a3a006d7-22b4-92fb-6613-150ae97c16b9@loongson.cn> (raw)
In-Reply-To: <e420ed19-c7a1-4f1e-a625-f5caef8492ea@linaro.org>
在 2023/12/27 下午4:49, Philippe Mathieu-Daudé 写道:
> Hi,
>
> On 27/12/23 09:08, Song Gao wrote:
>> Add init_cmline and set boot_info->a0, a1
>>
>> Signed-off-by: Song Gao <gaosong@loongson.cn>
>> ---
>> hw/loongarch/boot.c | 20 ++++++++++++++++++++
>> target/loongarch/cpu.h | 2 ++
>> 2 files changed, 22 insertions(+)
>>
>> diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c
>> index faff880153..27eae6f0cb 100644
>> --- a/hw/loongarch/boot.c
>> +++ b/hw/loongarch/boot.c
>> @@ -13,6 +13,7 @@
>> #include "elf.h"
>> #include "qemu/error-report.h"
>> #include "sysemu/reset.h"
>> +#include <asm-generic/setup.h>
>
> Build failure on Darwin host:
>
> [1135/1207] Compiling C object
> libqemu-loongarch64-softmmu.fa.p/hw_loongarch_boot.c.o
> FAILED: libqemu-loongarch64-softmmu.fa.p/hw_loongarch_boot.c.o
> ../../hw/loongarch/boot.c:16:10: fatal error: 'asm-generic/setup.h'
> file not found
> #include <asm-generic/setup.h>
> ^~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> ninja: build stopped: subcommand failed.
I will drop it , use #define COMAND_LINE_SIZE 512.
Thanks.
Song Gao
next prev parent reply other threads:[~2023-12-28 1:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 8:08 [PATCH v3 00/17] Add boot LoongArch elf kernel with FDT Song Gao
2023-12-27 8:08 ` [PATCH v3 01/17] hw/loongarch: Move boot fucntions to boot.c Song Gao
2023-12-27 8:08 ` [PATCH v3 02/17] hw/loongarch: Add load initrd Song Gao
2023-12-27 8:08 ` [PATCH v3 03/17] hw/loongarch: Add slave cpu boot_code Song Gao
2023-12-27 8:52 ` Philippe Mathieu-Daudé
2023-12-28 1:06 ` gaosong
2023-12-27 8:08 ` [PATCH v3 04/17] hw/loongarch: Add init_cmdline Song Gao
2023-12-27 8:49 ` Philippe Mathieu-Daudé
2023-12-28 1:06 ` gaosong [this message]
2023-12-27 8:08 ` [PATCH v3 05/17] hw/loongarch: Init efi_system_table Song Gao
2023-12-27 8:08 ` [PATCH v3 06/17] hw/loongarch: Init efi_boot_memmap table Song Gao
2023-12-27 8:08 ` [PATCH v3 07/17] hw/loongarch: Init efi_initrd table Song Gao
2023-12-27 8:08 ` [PATCH v3 08/17] hw/loongarch: Init efi_fdt table Song Gao
2023-12-27 8:08 ` [PATCH v3 09/17] hw/loongarch: Fix fdt memory node wrong 'reg' Song Gao
2023-12-27 8:08 ` [PATCH v3 10/17] hw/loongarch: fdt adds cpu interrupt controller node Song Gao
2023-12-27 8:08 ` [PATCH v3 11/17] hw/loongarch: fdt adds Extend I/O Interrupt Controller Song Gao
2023-12-27 9:02 ` Philippe Mathieu-Daudé
2023-12-28 1:06 ` gaosong
2023-12-27 8:08 ` [PATCH v3 12/17] hw/loongarch: fdt adds pch_pic Controller Song Gao
2023-12-27 8:08 ` [PATCH v3 13/17] hw/loongarch: fdt adds pch_msi Controller Song Gao
2023-12-27 8:08 ` [PATCH v3 14/17] hw/loongarch: fdt adds pcie irq_map node Song Gao
2023-12-27 8:08 ` [PATCH v3 15/17] hw/loongarch: fdt remove unused irqchip node Song Gao
2023-12-27 8:08 ` [PATCH v3 16/17] hw/loongarch: Add cells missing from uart node Song Gao
2023-12-27 8:08 ` [PATCH v3 17/17] hw/loongarch: Add cells missing from rtc node Song Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3a006d7-22b4-92fb-6613-150ae97c16b9@loongson.cn \
--to=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).