From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: cohuck@redhat.com
Subject: Re: [Qemu-devel] [PATCH] target/s390x: Use tcg_gen_gvec_bitsel
Date: Mon, 3 Jun 2019 16:59:37 -0500 [thread overview]
Message-ID: <a3b3cf27-0ba0-57ee-dd1b-fad753093742@linaro.org> (raw)
In-Reply-To: <c001abca-9de5-91eb-de00-fd8fb8249f59@redhat.com>
On 6/3/19 2:41 PM, David Hildenbrand wrote:
>> -static void gen_sel_vec(unsigned vece, TCGv_vec d, TCGv_vec a, TCGv_vec b,
>> - TCGv_vec c)
>> -{
>> - TCGv_vec t = tcg_temp_new_vec_matching(d);
>> -
>> - tcg_gen_andc_vec(vece, t, b, c);
>> - tcg_gen_and_vec(vece, d, a, c);
>> - tcg_gen_or_vec(vece, d, d, t);
>> - tcg_temp_free_vec(t);
>> -}
>> -
>
> Comparing against tcg_gen_bitsel_i64()
>
> 1. a and c are switched
> 2. b is _not_ switched (and() and andc() are switched)
Not quite. {a,b,c} from your s390 implementation becomes {c,a,b} for tcg.
Running tests would show for sure; I guess you have those later in your vx
patch set?
> Should I send this patch with the next s390x/tcg pull request?
Yes please.
r~
next prev parent reply other threads:[~2019-06-03 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 16:57 [Qemu-devel] [PATCH] target/s390x: Use tcg_gen_gvec_bitsel Richard Henderson
2019-06-03 19:41 ` David Hildenbrand
2019-06-03 21:59 ` Richard Henderson [this message]
2019-06-04 7:44 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3b3cf27-0ba0-57ee-dd1b-fad753093742@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).