From: Richard Henderson <richard.henderson@linaro.org>
To: Timothy E Baldwin <T.E.Baldwin99@members.leeds.ac.uk>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user: Correctly start brk after executable
Date: Wed, 29 Jul 2020 08:47:27 -0700 [thread overview]
Message-ID: <a3bb350d-030e-47dd-8c3f-223ddc40914f@linaro.org> (raw)
In-Reply-To: <20200728224615.326675-1-T.E.Baldwin99@members.leeds.ac.uk>
On 7/28/20 3:46 PM, Timothy E Baldwin wrote:
> info->brk was erroneously set to the end of highest addressed
> writable segment which could result it in overlapping the executable.
>
> As per load_elf_binary in fs/binfmt_elf.c in Linux, it should be
> set to end of highest addressed segment.
>
> Signed-off-by: Timothy E Baldwin <T.E.Baldwin99@members.leeds.ac.uk>
> ---
> linux-user/elfload.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-07-29 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 22:46 [PATCH] linux-user: Correctly start brk after executable Timothy E Baldwin
2020-07-29 15:47 ` Richard Henderson [this message]
2020-09-05 20:51 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3bb350d-030e-47dd-8c3f-223ddc40914f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=T.E.Baldwin99@members.leeds.ac.uk \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).