From: Richard Henderson <richard.henderson@linaro.org>
To: "Claudio Fontana" <cfontana@suse.de>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 2/3] accel/tcg: split tcg_start_vcpu_thread
Date: Wed, 14 Oct 2020 13:08:34 -0700 [thread overview]
Message-ID: <a3c48dd0-643b-a433-08b7-cdd637f2752d@linaro.org> (raw)
In-Reply-To: <20201014192324.6390-3-cfontana@suse.de>
On 10/14/20 12:23 PM, Claudio Fontana wrote:
> +++ b/accel/tcg/tcg-cpus-mttcg.h
> @@ -10,14 +10,4 @@
> #ifndef TCG_CPUS_MTTCG_H
> #define TCG_CPUS_MTTCG_H
>
> -/*
> - * Multi-threaded TCG
> - *
> - * In the multi-threaded case each vCPU has its own thread. The TLS
> - * variable current_cpu can be used deep in the code to find the
> - * current CPUState for a given thread.
> - */
> -
> -void *tcg_cpu_thread_fn(void *arg);
> -
> #endif /* TCG_CPUS_MTTCG_H */
Hum. Do we really need to create these headers in the previous patch? Because
now we have an empty one.
Why not just put all of tcg-cpus-*.h into tcg-cpus.h?
Otherwise this looks ok.
r~
next prev parent reply other threads:[~2020-10-14 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 19:23 [PATCH v2 0/3] tcg-cpus: split into 3 tcg variants Claudio Fontana
2020-10-14 19:23 ` [PATCH v2 1/3] accel/tcg: split CpusAccel into three TCG variants Claudio Fontana
2020-10-14 19:37 ` Philippe Mathieu-Daudé
2020-10-14 19:47 ` Richard Henderson
2020-10-14 19:23 ` [PATCH v2 2/3] accel/tcg: split tcg_start_vcpu_thread Claudio Fontana
2020-10-14 20:08 ` Richard Henderson [this message]
2020-10-15 12:33 ` Claudio Fontana
2020-10-15 13:28 ` Claudio Fontana
2020-10-14 19:23 ` [PATCH v2 3/3] accel/tcg: rename tcg-cpus functions to match module name Claudio Fontana
2020-10-14 19:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3c48dd0-643b-a433-08b7-cdd637f2752d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).