From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: zhaoguohan_salmon@163.com, kraxel@redhat.com
Cc: "open list:All patches CC here" <qemu-devel@nongnu.org>,
GuoHan Zhao <zhaoguohan@kylinos.cn>
Subject: Re: [PATCH] hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log
Date: Thu, 23 Oct 2025 10:18:36 +0200 [thread overview]
Message-ID: <a3ce5f41-359f-47d5-9edc-7a2eb47d4e15@linaro.org> (raw)
In-Reply-To: <20251023063106.9834-1-zhaoguohan_salmon@163.com>
On 23/10/25 08:31, zhaoguohan_salmon@163.com wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
>
> The FirmwareLog object returned by qmp_query_firmware_log() was
> not being freed, causing a memory leak.
>
> Use g_autoptr to ensure the object is automatically freed when
> it goes out of scope.
>
> Fixes: c8aa8120313f ("hw/uefi: add 'info firmware-log' hmp monitor command.")
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
> ---
> hw/uefi/ovmf-log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-10-23 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 6:31 [PATCH] hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log zhaoguohan_salmon
2025-10-23 8:18 ` Philippe Mathieu-Daudé [this message]
2025-10-27 19:15 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ce5f41-359f-47d5-9edc-7a2eb47d4e15@linaro.org \
--to=philmd@linaro.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhaoguohan@kylinos.cn \
--cc=zhaoguohan_salmon@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).