From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8413C02194 for ; Thu, 6 Feb 2025 09:25:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tfy7y-0005x3-44; Thu, 06 Feb 2025 04:24:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tfy7v-0005w1-Lk for qemu-devel@nongnu.org; Thu, 06 Feb 2025 04:24:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tfy7t-0002hf-UN for qemu-devel@nongnu.org; Thu, 06 Feb 2025 04:24:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738833889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iEslA6bpm6I2ka9slSMN2xvhhF5MmqNKV2dk1ANZ2gI=; b=eAuacashgSjjCqwM5uzeymr+CoIgY67jZN14np3FPRwpDexDSLHOBGnwKYeMWfqXyz+6+f 6OGCjxlYuEaA2lfllBvrk7FXdji72PoOBJMwSHPyaZ6qR2rDJxfqSRFoELn3qxB0lweUXV gZE8VziSXMDzEZxjIbw5Bme+AJV1xik= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-0rUUL9Y-OAytSISjybcEpw-1; Thu, 06 Feb 2025 04:24:47 -0500 X-MC-Unique: 0rUUL9Y-OAytSISjybcEpw-1 X-Mimecast-MFC-AGG-ID: 0rUUL9Y-OAytSISjybcEpw Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361efc9d1fso5303465e9.2 for ; Thu, 06 Feb 2025 01:24:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738833886; x=1739438686; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iEslA6bpm6I2ka9slSMN2xvhhF5MmqNKV2dk1ANZ2gI=; b=rxQ7/3nCkbg5OqSsmCxpKAKrjdcNdRJbWprNQaJgmKZ+rryTj+i49Fe+Df89tc6dsv 7vBjFThoxnEJl1t93LhKJlMT7rfzuuohRt1EcebQUrLgDMMVr6GWo+OdXLrwoA3WTmRy ppJHDTgukEVig2R7Jy0o7DGszL7ZPKSpWFtB6RAGNGZHZh9g5S3Q6OiGkpnVfEtIkTz7 VZtU1kd423+yPgsV5psrsdq1WlVkFZfICvA9+/LE61uZR6kKEpaEaoWjGlaWPiu6wDo8 sDlvBws+Ab9TWbEtVKu8laQf7vrUkvUygKUmlfPPhvGQt903h31P74nVbc8KQDad2tm4 jiOQ== X-Forwarded-Encrypted: i=1; AJvYcCX3P5xRysA0goIHjSS9dVvSq402ewRaVu5DZX0xsaE4pEkDwuZZH7+p/HTzMYmD/RVbqQ3dzSOOz1IZ@nongnu.org X-Gm-Message-State: AOJu0YxbjdRlh3YRh345OBvG7tXgJeL5Ybvq4J4iOdPa7wmYevIjmEgG FCqR8CdJUm6XN0nXP+/KLRjvbb3+nA4V9j71sHr+wREEyWjEriT6ZXwL93JdAHGmiZPkjSuN3P1 YHW29iMFnbCg2JNd4k+TdJyAciusOlNqH2TU3vrhTj4ppy+t9dg2V X-Gm-Gg: ASbGncuOxS0nxZUMFsMlGoUC79Ie9OakMY62rGnBfTFONyy+u0sVHqp6s8tY6vlWiFQ 4m3Lb1LExfrLuaUQxT4G8oTI/tBV2gqaUfczMmNPEOzlaI5ZK9DsBkW9LIVHS4rIe39Xd4pTUqC IT6k78gPwjbVcRe+W3j2l8IQAUIzC/dJQNVEJBqNJgn1XlTE8xHpc8eJ7Y301CVo4aoh3JUAYKM il7/ZYfZ7RRwa6zBOxeTL78HriduEBFY3oyZF9LzJbAs9NBY8sHnF0e3SYDH1TNfcS119euqSCW 0PlcSspVBnsd5R7Cn/whfjFC3+V8mNTZFW01 X-Received: by 2002:a05:600c:1c1a:b0:438:d9ae:337b with SMTP id 5b1f17b1804b1-4390d43de60mr45559145e9.17.1738833886464; Thu, 06 Feb 2025 01:24:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKWh6Ln273oQJSl/pK5nSmzRk+wUTrgGWikrL+/qAJgMdzOznRB2R/Xgmmr3SYkFdDdpXX9g== X-Received: by 2002:a05:600c:1c1a:b0:438:d9ae:337b with SMTP id 5b1f17b1804b1-4390d43de60mr45558965e9.17.1738833886109; Thu, 06 Feb 2025 01:24:46 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-48-132.web.vodafone.de. [109.42.48.132]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390db10b17sm47780285e9.34.2025.02.06.01.24.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2025 01:24:45 -0800 (PST) Message-ID: Date: Thu, 6 Feb 2025 10:24:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] tests/functional: set 'qemu_bin' as an object level field To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= References: <20250205155946.2811296-1-berrange@redhat.com> <20250205155946.2811296-4-berrange@redhat.com> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250205155946.2811296-4-berrange@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 05/02/2025 16.59, Daniel P. Berrangé wrote: > The 'qemu_bin' field is currently set on the class, despite being > accessed as if it were an object instance field with 'self.qemu_bin'. > > This is no obvious need to have it as a class field, so move it into > the object instance. > > Signed-off-by: Daniel P. Berrangé > --- > docs/devel/testing/functional.rst | 2 +- > tests/functional/qemu_test/testcase.py | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth