From: Richard Henderson <richard.henderson@linaro.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: peter.maydell@linaro.org,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
alex.bennee@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/3] target/arm: Complete ISS for MTE tag check fail
Date: Wed, 12 Aug 2020 11:00:19 -0700 [thread overview]
Message-ID: <a3d0f05e-1e76-5c5a-4be9-506dab0e6e9d@linaro.org> (raw)
In-Reply-To: <b2d524a2-1523-d03a-72a9-407ab03fa897@linaro.org>
On 8/12/20 10:52 AM, Richard Henderson wrote:
> On 8/12/20 10:38 AM, Andrey Konovalov wrote:
>> On Wed, Aug 12, 2020 at 7:19 PM Richard Henderson
>> <richard.henderson@linaro.org> wrote:
>>>
>>> As reported by Andrey, I was missing the complete ISS info for
>>> the Data Abort raised upon a synchronous tag check fail.
>>>
>>> The following should fix that. All the twisty little rules for
>>> the ISS.ISV bit are already handled by merge_syn_data_abort.
>>> Probably the most important bit that was missing was ISS.WnR,
>>> as that is independent of ISS.ISV.
>>>
>>> Andrey, will you please test?
>>
>> Looks like WnR is now being set properly, but SAS is still always 0.
>
> Are you looking at ESR_EL1?
>
> On page D13-2992 of revision F.a:
>
> # ISV is 0 for all faults reported in ESR_EL1 or ESR_EL3.
>
> which means that ISS[23:14] are RES0, which includes SAS.
Actually, note that AArch64.TagCheckFault never fills in anything except WnR.
So the final patch here merging the recorded syndrome information is wrong. I
was only missing WnR in the original implementation.
r~
next prev parent reply other threads:[~2020-08-12 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 17:19 [PATCH 0/3] target/arm: Complete ISS for MTE tag check fail Richard Henderson
2020-08-12 17:19 ` [PATCH 1/3] target/arm: Export merge_syn_data_abort from tlb_helper.c Richard Henderson
2020-08-12 17:19 ` [PATCH 2/3] target/arm: Pass the entire mte descriptor to mte_check_fail Richard Henderson
2020-08-12 17:19 ` [PATCH 3/3] target/arm: Merge ISS for data abort from tag check fail Richard Henderson
2020-08-12 17:38 ` [PATCH 0/3] target/arm: Complete ISS for MTE " Andrey Konovalov
2020-08-12 17:52 ` Richard Henderson
2020-08-12 18:00 ` Richard Henderson [this message]
2020-08-12 18:02 ` Andrey Konovalov
2020-08-12 19:06 ` Evgenii Stepanov
2020-08-13 10:01 ` Kevin Brodsky
2020-08-13 12:26 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3d0f05e-1e76-5c5a-4be9-506dab0e6e9d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=andreyknvl@google.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).