From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: [PATCH 01/17] block/nvme: Avoid further processing if trace event not enabled
Date: Fri, 26 Jun 2020 16:02:43 +0200 [thread overview]
Message-ID: <a3d7754c-38d8-ec9a-18d8-1a489d0c55ba@redhat.com> (raw)
In-Reply-To: <20200626103651.GH281902@stefanha-x1.localdomain>
On 6/26/20 12:36 PM, Stefan Hajnoczi wrote:
> On Thu, Jun 25, 2020 at 08:48:22PM +0200, Philippe Mathieu-Daudé wrote:
>> Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is
>> not enabled.
>
> Why?
>
> This saves 8 trace events, each with 8 arguments. I guess the intent is
> to improve performance. Did you measure an improvement?
No testing, I just tried to outsmart the compiler :/
next prev parent reply other threads:[~2020-06-26 14:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 18:48 [PATCH 00/17] block/nvme: Various cleanups required to use multiple queues Philippe Mathieu-Daudé
2020-06-25 18:48 ` [PATCH 01/17] block/nvme: Avoid further processing if trace event not enabled Philippe Mathieu-Daudé
2020-06-26 10:36 ` Stefan Hajnoczi
2020-06-26 14:02 ` Philippe Mathieu-Daudé [this message]
2020-06-29 13:02 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 02/17] block/nvme: Let nvme_create_queue_pair() fail gracefully Philippe Mathieu-Daudé
2020-06-26 11:11 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 03/17] block/nvme: Define QUEUE_INDEX macros to ease code review Philippe Mathieu-Daudé
2020-06-26 11:12 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 04/17] block/nvme: Be explicit we share NvmeIdCtrl / NvmeIdNs structures Philippe Mathieu-Daudé
2020-06-26 11:19 ` Stefan Hajnoczi
2020-06-26 12:45 ` Philippe Mathieu-Daudé
2020-06-25 18:48 ` [PATCH 05/17] block/nvme: Replace qemu_try_blockalign0 by qemu_try_blockalign/memset Philippe Mathieu-Daudé
2020-06-26 12:20 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 06/17] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz) Philippe Mathieu-Daudé
2020-06-26 12:24 ` Stefan Hajnoczi
2020-06-26 12:48 ` Philippe Mathieu-Daudé
2020-06-29 13:07 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 07/17] block/nvme: Move code around Philippe Mathieu-Daudé
2020-06-26 12:25 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 08/17] block/nvme: Use correct type void* Philippe Mathieu-Daudé
2020-06-26 12:31 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 09/17] block/nvme: Remove unused argument from nvme_free_queue_pair() Philippe Mathieu-Daudé
2020-06-26 12:31 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 10/17] block/nvme: Simplify nvme_init_queue() arguments Philippe Mathieu-Daudé
2020-06-26 12:31 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 11/17] block/nvme: Simplify nvme_create_queue_pair() arguments Philippe Mathieu-Daudé
2020-06-26 12:31 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 12/17] block/nvme: Simplify nvme_kick trace event Philippe Mathieu-Daudé
2020-06-26 12:33 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 13/17] block/nvme: Simplify completion trace events Philippe Mathieu-Daudé
2020-06-26 12:34 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 14/17] block/nvme: Replace BDRV_POLL_WHILE by AIO_WAIT_WHILE Philippe Mathieu-Daudé
2020-06-26 12:35 ` Stefan Hajnoczi
2020-06-25 18:48 ` [RFC PATCH 15/17] block/nvme: Use per-queue AIO context Philippe Mathieu-Daudé
2020-06-26 12:42 ` Stefan Hajnoczi
2020-06-26 12:59 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 16/17] block/nvme: Check BDRVNVMeState::plugged out of nvme_kick() Philippe Mathieu-Daudé
2020-06-26 12:43 ` Stefan Hajnoczi
2020-06-25 18:48 ` [PATCH 17/17] block/nvme: Check BDRVNVMeState::plugged out of nvme_process_completion Philippe Mathieu-Daudé
2020-06-26 12:46 ` Stefan Hajnoczi
2020-06-25 19:27 ` [PATCH 00/17] block/nvme: Various cleanups required to use multiple queues no-reply
2020-06-26 9:18 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3d7754c-38d8-ec9a-18d8-1a489d0c55ba@redhat.com \
--to=philmd@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).