* [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES
@ 2023-03-14 22:08 Max Filippov
2023-03-14 23:41 ` Wilfred Mallawa
2023-03-15 7:48 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 5+ messages in thread
From: Max Filippov @ 2023-03-14 22:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Max Filippov
Linker script for xtensa tests must be preprocessed for a specific
target, remove it as a part of make clean.
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
tests/tcg/xtensa/Makefile.softmmu-target | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/tcg/xtensa/Makefile.softmmu-target b/tests/tcg/xtensa/Makefile.softmmu-target
index 973e55298ee4..948c0e6506bd 100644
--- a/tests/tcg/xtensa/Makefile.softmmu-target
+++ b/tests/tcg/xtensa/Makefile.softmmu-target
@@ -26,6 +26,7 @@ ASFLAGS = -Wa,--no-absolute-literals
LDFLAGS = -Tlinker.ld -nostartfiles -nostdlib
CRT = crt.o vectors.o
+CLEANFILES += linker.ld
linker.ld: linker.ld.S
$(CC) $(XTENSA_INC) -E -P $< -o $@
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES
2023-03-14 22:08 [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES Max Filippov
@ 2023-03-14 23:41 ` Wilfred Mallawa
2023-03-15 0:08 ` Max Filippov
2023-03-15 7:48 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 5+ messages in thread
From: Wilfred Mallawa @ 2023-03-14 23:41 UTC (permalink / raw)
To: jcmvbkbc@gmail.com, qemu-devel@nongnu.org
On Tue, 2023-03-14 at 15:08 -0700, Max Filippov wrote:
> Linker script for xtensa tests must be preprocessed for a specific
> target, remove it as a part of make clean.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> tests/tcg/xtensa/Makefile.softmmu-target | 1 +
> 1 file changed, 1 insertion(+)
Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> diff --git a/tests/tcg/xtensa/Makefile.softmmu-target
> b/tests/tcg/xtensa/Makefile.softmmu-target
> index 973e55298ee4..948c0e6506bd 100644
> --- a/tests/tcg/xtensa/Makefile.softmmu-target
> +++ b/tests/tcg/xtensa/Makefile.softmmu-target
> @@ -26,6 +26,7 @@ ASFLAGS = -Wa,--no-absolute-literals
> LDFLAGS = -Tlinker.ld -nostartfiles -nostdlib
>
> CRT = crt.o vectors.o
> +CLEANFILES += linker.ld
>
> linker.ld: linker.ld.S
> $(CC) $(XTENSA_INC) -E -P $< -o $@
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES
2023-03-14 23:41 ` Wilfred Mallawa
@ 2023-03-15 0:08 ` Max Filippov
2023-03-15 0:49 ` Wilfred Mallawa
0 siblings, 1 reply; 5+ messages in thread
From: Max Filippov @ 2023-03-15 0:08 UTC (permalink / raw)
To: Wilfred Mallawa; +Cc: qemu-devel@nongnu.org
On Tue, Mar 14, 2023 at 4:41 PM Wilfred Mallawa <wilfred.mallawa@wdc.com> wrote:
>
> On Tue, 2023-03-14 at 15:08 -0700, Max Filippov wrote:
> > Linker script for xtensa tests must be preprocessed for a specific
> > target, remove it as a part of make clean.
> >
> > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> > ---
> > tests/tcg/xtensa/Makefile.softmmu-target | 1 +
> > 1 file changed, 1 insertion(+)
> Wilfred Mallawa <wilfred.mallawa@wdc.com>
The tag is missing, I assume you meant Reviewed-by.
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES
2023-03-15 0:08 ` Max Filippov
@ 2023-03-15 0:49 ` Wilfred Mallawa
0 siblings, 0 replies; 5+ messages in thread
From: Wilfred Mallawa @ 2023-03-15 0:49 UTC (permalink / raw)
To: jcmvbkbc@gmail.com; +Cc: qemu-devel@nongnu.org
On Tue, 2023-03-14 at 17:08 -0700, Max Filippov wrote:
> On Tue, Mar 14, 2023 at 4:41 PM Wilfred Mallawa
> <wilfred.mallawa@wdc.com> wrote:
> >
> > On Tue, 2023-03-14 at 15:08 -0700, Max Filippov wrote:
> > > Linker script for xtensa tests must be preprocessed for a
> > > specific
> > > target, remove it as a part of make clean.
> > >
> > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> > > ---
> > > tests/tcg/xtensa/Makefile.softmmu-target | 1 +
> > > 1 file changed, 1 insertion(+)
>
> > Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> The tag is missing, I assume you meant Reviewed-by.
Ah crap, sorry! yes I did.
Wilfred
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES
2023-03-14 22:08 [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES Max Filippov
2023-03-14 23:41 ` Wilfred Mallawa
@ 2023-03-15 7:48 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-03-15 7:48 UTC (permalink / raw)
To: Max Filippov, qemu-devel
On 14/3/23 23:08, Max Filippov wrote:
> Linker script for xtensa tests must be preprocessed for a specific
> target, remove it as a part of make clean.
>
Fixes: be5cac175a ("tests/tcg/xtensa: enable system tests")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> tests/tcg/xtensa/Makefile.softmmu-target | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/tcg/xtensa/Makefile.softmmu-target b/tests/tcg/xtensa/Makefile.softmmu-target
> index 973e55298ee4..948c0e6506bd 100644
> --- a/tests/tcg/xtensa/Makefile.softmmu-target
> +++ b/tests/tcg/xtensa/Makefile.softmmu-target
> @@ -26,6 +26,7 @@ ASFLAGS = -Wa,--no-absolute-literals
> LDFLAGS = -Tlinker.ld -nostartfiles -nostdlib
>
> CRT = crt.o vectors.o
> +CLEANFILES += linker.ld
>
> linker.ld: linker.ld.S
> $(CC) $(XTENSA_INC) -E -P $< -o $@
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-15 7:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-14 22:08 [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES Max Filippov
2023-03-14 23:41 ` Wilfred Mallawa
2023-03-15 0:08 ` Max Filippov
2023-03-15 0:49 ` Wilfred Mallawa
2023-03-15 7:48 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).