From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1z9f-00035i-NS for qemu-devel@nongnu.org; Tue, 10 Oct 2017 14:21:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1z9a-00054a-N2 for qemu-devel@nongnu.org; Tue, 10 Oct 2017 14:21:23 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33328 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1z9a-00054R-HD for qemu-devel@nongnu.org; Tue, 10 Oct 2017 14:21:18 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9AIImWJ054311 for ; Tue, 10 Oct 2017 14:21:14 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0a-001b2d01.pphosted.com with ESMTP id 2dh2snt64u-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 10 Oct 2017 14:21:13 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Oct 2017 12:21:13 -0600 References: <20171009225623.29232-1-marcandre.lureau@redhat.com> <20171009225623.29232-42-marcandre.lureau@redhat.com> From: Stefan Berger Date: Tue, 10 Oct 2017 14:21:09 -0400 MIME-Version: 1.0 In-Reply-To: <20171009225623.29232-42-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 41/42] tpm-emulator: add a FIXME comment about blocking cancel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: amarnath.valluri@intel.com On 10/09/2017 06:56 PM, Marc-Andr=C3=A9 Lureau wrote: > Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Berger > --- > hw/tpm/tpm_emulator.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c > index 315819329b..091d7ea147 100644 > --- a/hw/tpm/tpm_emulator.c > +++ b/hw/tpm/tpm_emulator.c > @@ -328,6 +328,7 @@ static void tpm_emulator_cancel_cmd(TPMBackend *tb) > return; > } > =20 > + /* FIXME: make the function non-blocking, or it may block a VCPU *= / > if (tpm_emulator_ctrlcmd(&tpm_emu->ctrl_chr, CMD_CANCEL_TPM_CMD, = &res, 0, > sizeof(res)) < 0) { > error_report("tpm-emulator: Could not cancel command: %s",