From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, ronniesahlberg@gmail.com,
codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, den@openvz.org
Subject: Re: [PATCH 3/8] block/crypto: drop unallocated_blocks_are_zero
Date: Wed, 6 May 2020 16:21:30 -0500 [thread overview]
Message-ID: <a3ff4704-9508-172c-877c-4aab1660e6d3@redhat.com> (raw)
In-Reply-To: <20200506092513.20904-4-vsementsov@virtuozzo.com>
On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote:
> It's false by default, no needs to set it. We are going to drop this
> variable at all, so drop it now here, it doesn't hurt.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/crypto.c | 1 -
> 1 file changed, 1 deletion(-)
Trivially correct, regardless of clients.
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/crypto.c b/block/crypto.c
> index e02f343590..7685e61844 100644
> --- a/block/crypto.c
> +++ b/block/crypto.c
> @@ -694,7 +694,6 @@ static int block_crypto_get_info_luks(BlockDriverState *bs,
> return ret;
> }
>
> - bdi->unallocated_blocks_are_zero = false;
> bdi->cluster_size = subbdi.cluster_size;
>
> return 0;
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-06 21:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 9:25 [PATCH 0/8] drop unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-06 9:25 ` [PATCH 1/8] block/vdi: return ZERO block-status when appropriate Vladimir Sementsov-Ogievskiy
2020-05-06 13:57 ` Eric Blake
2020-05-06 14:49 ` Vladimir Sementsov-Ogievskiy
2020-05-07 7:22 ` Vladimir Sementsov-Ogievskiy
2020-05-06 9:25 ` [PATCH 2/8] block/vpc: " Vladimir Sementsov-Ogievskiy
2020-05-06 21:18 ` Eric Blake
2020-05-07 7:08 ` Vladimir Sementsov-Ogievskiy
2020-05-06 9:25 ` [PATCH 3/8] block/crypto: drop unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-06 21:21 ` Eric Blake [this message]
2020-05-06 9:25 ` [PATCH 4/8] block/iscsi: " Vladimir Sementsov-Ogievskiy
2020-05-06 21:25 ` Eric Blake
2020-05-06 9:25 ` [PATCH 5/8] block/file-posix: " Vladimir Sementsov-Ogievskiy
2020-05-06 21:41 ` Eric Blake
2020-05-06 9:25 ` [PATCH 6/8] block/vhdx: " Vladimir Sementsov-Ogievskiy
2020-05-06 21:43 ` Eric Blake
2020-05-06 9:25 ` [PATCH 7/8] qemu-img: convert: don't use unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-06 14:49 ` Eric Blake
2020-05-06 14:58 ` Vladimir Sementsov-Ogievskiy
2020-05-06 9:25 ` [PATCH 8/8] block: drop unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-06 15:14 ` Eric Blake
2020-05-06 15:30 ` Vladimir Sementsov-Ogievskiy
2020-05-07 7:05 ` Vladimir Sementsov-Ogievskiy
2020-05-07 8:24 ` Vladimir Sementsov-Ogievskiy
2020-05-07 8:35 ` Vladimir Sementsov-Ogievskiy
2020-05-06 15:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ff4704-9508-172c-877c-4aab1660e6d3@redhat.com \
--to=eblake@redhat.com \
--cc=codyprime@gmail.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).