From: Paolo Bonzini <pbonzini@redhat.com>
To: Robert Hoo <robert.hu@linux.intel.com>
Cc: qemu-devel@nongnu.org, rth@twiddle.net, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs
Date: Tue, 26 Jun 2018 11:20:23 +0200 [thread overview]
Message-ID: <a3ffd8fc-e352-5719-0b46-c25697c4be02@redhat.com> (raw)
In-Reply-To: <1530003511.22880.5.camel@linux.intel.com>
On 26/06/2018 10:58, Robert Hoo wrote:
>> This is not needed, because pred_cmd is write only and arch_capabilities
>> is read only. The guest cannot modify any of them.
>>
> Thanks Paolo. Yes, indeed unnecessary.
> I looked into the
> 336996-Speculative-Execution-Side-Channel-Mitigations.pdf again, looks
> like the vmstate_spec_ctrl is similar to pred_cmd, wirte only. Shall I
> remove it as well in v2 patch?
No, spec_ctrl is read-write.
Paolo
next prev parent reply other threads:[~2018-06-26 9:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 3:39 [Qemu-devel] [PATCH 0/5] Add Icelake CPU model Robert Hoo
2018-06-25 3:39 ` [Qemu-devel] [PATCH 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs Robert Hoo
2018-06-25 11:51 ` Paolo Bonzini
2018-06-26 8:58 ` Robert Hoo
2018-06-26 9:20 ` Paolo Bonzini [this message]
2018-06-25 3:39 ` [Qemu-devel] [PATCH 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR Robert Hoo
2018-06-25 12:06 ` Paolo Bonzini
2018-06-26 11:07 ` Robert Hoo
2018-06-28 18:30 ` Eduardo Habkost
2018-06-29 11:34 ` Paolo Bonzini
2018-06-29 17:30 ` Eduardo Habkost
2018-06-25 3:39 ` [Qemu-devel] [PATCH 3/5] i386: Add CPUID bit for PCONFIG Robert Hoo
2018-06-25 3:39 ` [Qemu-devel] [PATCH 4/5] i386: Add CPUID bit for WBNOINVD Robert Hoo
2018-06-25 3:39 ` [Qemu-devel] [PATCH 5/5] i386: Add new CPU model Icelake-{Server, Client} Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ffd8fc-e352-5719-0b46-c25697c4be02@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.hu@linux.intel.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).