From: Max Reitz <mreitz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] scsi-generic: keep VPD page list sorted
Date: Tue, 6 Nov 2018 02:45:14 +0100 [thread overview]
Message-ID: <a412ed2c-bcf2-8825-c2bc-45fad8b99d1f@redhat.com> (raw)
In-Reply-To: <20181029173437.32559-2-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On 29.10.18 18:34, Paolo Bonzini wrote:
> Block limits emulation is just placing 0xb0 as the final byte of the
> VPD pages list. However, VPD page numbers must be sorted, so change
> that to an in-place insert. Since I couldn't find any disk that triggered
> the loop more than once, this was tested by adding manually 0xb1
> at the end of the list and checking that 0xb0 was added before.
>
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/scsi/scsi-generic.c | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-06 2:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 17:34 [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation Paolo Bonzini
2018-10-29 17:34 ` [Qemu-devel] [PATCH 1/4] scsi-generic: keep VPD page list sorted Paolo Bonzini
2018-11-06 1:45 ` Max Reitz [this message]
2018-11-06 15:39 ` Daniel Henrique Barboza
2018-10-29 17:34 ` [Qemu-devel] [PATCH 2/4] scsi-generic: avoid out-of-bounds access to VPD page list Paolo Bonzini
2018-10-30 21:26 ` Philippe Mathieu-Daudé
2018-11-06 1:52 ` Max Reitz
2018-11-06 15:40 ` Daniel Henrique Barboza
2018-10-29 17:34 ` [Qemu-devel] [PATCH 3/4] scsi-generic: avoid invalid access to struct when emulating block limits Paolo Bonzini
2018-11-06 2:16 ` Max Reitz
2018-11-06 9:44 ` Paolo Bonzini
2018-10-29 17:34 ` [Qemu-devel] [PATCH 4/4] scsi-generic: do not do VPD emulation for sense other than ILLEGAL_REQUEST Paolo Bonzini
2018-11-06 2:22 ` Max Reitz
2018-10-31 23:17 ` [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation no-reply
2018-10-31 23:27 ` no-reply
2018-11-06 15:31 ` no-reply
2018-11-06 15:42 ` no-reply
2018-11-06 15:54 ` Daniel Henrique Barboza
2018-11-06 18:54 ` Paolo Bonzini
2018-11-07 11:36 ` no-reply
2018-11-07 11:46 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a412ed2c-bcf2-8825-c2bc-45fad8b99d1f@redhat.com \
--to=mreitz@redhat.com \
--cc=danielhb413@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).