From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
qemu-devel@nongnu.org
Cc: smarkovic@wavecomp.com, arikalo@wavecomp.com,
amarkovic@wavecomp.com, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/6] target/mips: nanoMIPS: Remove an unused macro
Date: Mon, 21 Jan 2019 21:19:56 +0100 [thread overview]
Message-ID: <a414c064-daca-42e4-76fb-8cde4895274a@redhat.com> (raw)
In-Reply-To: <1548097698-28951-3-git-send-email-aleksandar.markovic@rt-rk.com>
On 1/21/19 8:08 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> Remove a macro that is never used.
>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/mips/translate.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index fb2c42c..aad760c 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -18393,7 +18393,6 @@ enum {
>
> #define NANOMIPS_EXTRACT_RD(op) ((op >> 7) & 0x7)
> #define NANOMIPS_EXTRACT_RS(op) ((op >> 4) & 0x7)
> -#define NANOMIPS_EXTRACT_RS2(op) uMIPS_RS(op)
> #define NANOMIPS_EXTRACT_RS1(op) ((op >> 1) & 0x7)
> #define NANOMIPS_EXTRACT_RD5(op) ((op >> 5) & 0x1f)
> #define NANOMIPS_EXTRACT_RS5(op) (op & 0x1f)
>
next prev parent reply other threads:[~2019-01-21 20:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 19:08 [Qemu-devel] [PATCH 0/6] target/mips: Misc fixes Aleksandar Markovic
2019-01-21 19:08 ` [Qemu-devel] [PATCH 1/6] target/mips: nanoMIPS: Remove duplicate macro definitions Aleksandar Markovic
2019-01-21 20:19 ` Philippe Mathieu-Daudé
2019-01-21 19:08 ` [Qemu-devel] [PATCH 2/6] target/mips: nanoMIPS: Remove an unused macro Aleksandar Markovic
2019-01-21 20:19 ` Philippe Mathieu-Daudé [this message]
2019-01-21 19:08 ` [Qemu-devel] [PATCH 3/6] target/mips: nanoMIPS: Rename macros for extracting 3-bit GPR codes Aleksandar Markovic
2019-01-21 19:08 ` [Qemu-devel] [PATCH 4/6] target/mips: Correct the second argument type of cpu_supports_isa() Aleksandar Markovic
2019-01-21 20:23 ` Philippe Mathieu-Daudé
2019-01-21 19:08 ` [Qemu-devel] [PATCH 5/6] target/mips: Extend gen_scwp() functionality to support EVA Aleksandar Markovic
2019-01-21 19:08 ` [Qemu-devel] [PATCH 6/6] disas: nanoMIPS: Amend DSP instructions related comments Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a414c064-daca-42e4-76fb-8cde4895274a@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=smarkovic@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).