From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSaV5-00049L-Hz for qemu-devel@nongnu.org; Wed, 27 Jul 2016 21:52:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSaV1-0006LK-DD for qemu-devel@nongnu.org; Wed, 27 Jul 2016 21:52:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSaV1-0006L0-7o for qemu-devel@nongnu.org; Wed, 27 Jul 2016 21:52:35 -0400 References: <1467714580-17581-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> <3b6da64b-3612-f16d-c3b0-75b50fa9a10c@redhat.com> From: Jason Wang Message-ID: Date: Thu, 28 Jul 2016 09:52:29 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH V3 0/3] filter-rewriter: introduce filter-rewriter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , qemu devel Cc: "eddie . dong" , Li Zhijian On 2016=E5=B9=B407=E6=9C=8827=E6=97=A5 15:52, Zhang Chen wrote: > > > On 07/27/2016 03:05 PM, Jason Wang wrote: >> >> >> On 2016=E5=B9=B407=E6=9C=8827=E6=97=A5 13:49, Zhang Chen wrote: >>> >>> >>> On 07/27/2016 10:50 AM, Jason Wang wrote: >>>> >>>> >>>> On 2016=E5=B9=B407=E6=9C=8827=E6=97=A5 10:32, Zhang Chen wrote: >>>>> Hi~ all~~ >>>>> >>>>> Anyone have some comments for this series? >>>> >>>> Will have a look at this. >>>> >>>> Btw. I wonder how this is tested, do we need a unit test for this? >>> >>> COLO-compare and filter-rewriter works normal depend on colo-frame. >>> So, When colo-frame be merged I will send a colo-proxy unit test >>> for all filter-mirror,filter-redirector,colo-compare,filter-rewriter. >> >> Sounds cool. >> >>> >>> >>>> >>>>> >>>>> We need more comments to improve COLO codes. >>>>> >>>>> >>>>> Thanks >>>>> >>>>> Zhang Chen >>>>> >>>>> >>>>> On 07/05/2016 06:29 PM, Zhang Chen wrote: >>>>>> Filter-rewriter is a part of COLO project. >>>>>> So this patch set depend on colo-compare. >>>> >>>> Interesting, I thought it can co-work with comparing, and the=20 >>>> communication were done through socket now. So I think technically=20 >>>> the filter itself could work without COLO? >>> >>> Filter-rewriter can run without COLO, but it no sense for other peopl= e. >>> rewriter need TX tcp packet differ with RX tcp packet... >>> In normal qemu we can't get the environment same with COLO. >>> >> >> Then I suggest to add this to the colo comparing series. > > OK~~ > BTW, Should we make independent the "qemu-char" patch to compare series= ? > This patch just add a API in qemu-char.c .... > > Thanks > Zhang Chen=20 I think yes, and better make it patch 1. Thanks