From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE4F5C76188 for ; Fri, 19 Jul 2019 14:34:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5BEA20873 for ; Fri, 19 Jul 2019 14:34:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5BEA20873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoTyH-0004pk-Sd for qemu-devel@archiver.kernel.org; Fri, 19 Jul 2019 10:34:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51230) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoTy7-0004GD-L8 for qemu-devel@nongnu.org; Fri, 19 Jul 2019 10:34:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoTy6-0002xu-Ix for qemu-devel@nongnu.org; Fri, 19 Jul 2019 10:34:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51722) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoTy3-0002vB-WD; Fri, 19 Jul 2019 10:34:40 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C9AE30C0DDD; Fri, 19 Jul 2019 14:34:38 +0000 (UTC) Received: from [10.3.116.46] (ovpn-116-46.phx2.redhat.com [10.3.116.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A3385D978; Fri, 19 Jul 2019 14:34:31 +0000 (UTC) To: Andrey Shinkevich , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <1563529204-3368-1-git-send-email-andrey.shinkevich@virtuozzo.com> <1563529204-3368-8-git-send-email-andrey.shinkevich@virtuozzo.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Fri, 19 Jul 2019 09:34:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1563529204-3368-8-git-send-email-andrey.shinkevich@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lsWG6jnGlJazm0fPWHaVFQ4MQStRgWg7s" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 19 Jul 2019 14:34:38 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v4 7/7] block/nbd: NBDReply is used being uninitialized X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, mreitz@redhat.com, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , den@openvz.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lsWG6jnGlJazm0fPWHaVFQ4MQStRgWg7s Content-Type: multipart/mixed; boundary="ZQHgvFcP0xcRe4y3jTu7T24KzZ20ruLs3"; protected-headers="v1" From: Eric Blake To: Andrey Shinkevich , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Subject: Re: [PATCH v4 7/7] block/nbd: NBDReply is used being uninitialized References: <1563529204-3368-1-git-send-email-andrey.shinkevich@virtuozzo.com> <1563529204-3368-8-git-send-email-andrey.shinkevich@virtuozzo.com> In-Reply-To: <1563529204-3368-8-git-send-email-andrey.shinkevich@virtuozzo.com> --ZQHgvFcP0xcRe4y3jTu7T24KzZ20ruLs3 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/19/19 4:40 AM, Andrey Shinkevich wrote: > In case nbd_co_receive_one_chunk() fails in > nbd_reply_chunk_iter_receive(), 'NBDReply reply' parameter is used in > the check nbd_reply_is_simple() without being initialized. The iotest > 083 does not pass under the Valgrind: $./check -nbd -valgrind 083. > The alternative solution is to swap the operands in the condition: > 'if (s->quit || nbd_reply_is_simple(reply))' >=20 > Signed-off-by: Andrey Shinkevich > --- > block/nbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Huh. Very similar to https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg03712.html, but affects a different function. I can queue this one through my NBD tree to get both in my rc2 pull request. Reviewed-by: Eric Blake >=20 > diff --git a/block/nbd.c b/block/nbd.c > index 81edabb..8480ad4 100644 > --- a/block/nbd.c > +++ b/block/nbd.c > @@ -786,7 +786,7 @@ static int nbd_co_receive_cmdread_reply(BDRVNBDStat= e *s, uint64_t handle, > int *request_ret, Error **errp= ) > { > NBDReplyChunkIter iter; > - NBDReply reply; > + NBDReply reply =3D {}; > void *payload =3D NULL; > Error *local_err =3D NULL; > =20 >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --ZQHgvFcP0xcRe4y3jTu7T24KzZ20ruLs3-- --lsWG6jnGlJazm0fPWHaVFQ4MQStRgWg7s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl0x1PYACgkQp6FrSiUn Q2plhwf+On53VMDWKXyQ+Z83gHNtyqtFraoz4ikvuyCYZaWSjOKfIC5C55FlKPoR vtzCZr76FWTrQTpWDwd0lubWCevHBNxLlsxsiaoq2dHF2lXwS3LgjcoIs7Wp0H+/ zKKJ4dH/LFdEu8SW22zF7RiTPTx//SjX89mjlpYWs7gXc3WNSWi5CcGbu/bk64Pt uAjqVMtxUV55PelYJppBsmoT1sZJDkL6as7DGIfDO3QUY0ie3t0UBr2GIDSdMwI/ 0hFSWfTsPBlHI1bBM+ozZhMMxWNKTd741JIJFJ4gy+AxnkOZ8MHfko1vZsNUZWWD EGRotypj3UUtvFEhYPxJ1tmyEaH5rA== =e+uM -----END PGP SIGNATURE----- --lsWG6jnGlJazm0fPWHaVFQ4MQStRgWg7s--