From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Rabin Vincent <rabin.vincent@axis.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Rabin Vincent <rabinv@axis.com>
Subject: Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining
Date: Thu, 8 Sep 2016 13:21:01 -0500 [thread overview]
Message-ID: <a42bad3b-aeaa-2aa7-5f4e-624103a293e2@redhat.com> (raw)
In-Reply-To: <CAFEAcA9+OHhbRi_0+fPkTkwJyPqX+uZoHqvi3e2z_n7CrNXh_Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On 09/08/2016 01:06 PM, Peter Maydell wrote:
>> +++ b/tests/tcg/cris/sys.h
>> @@ -3,6 +3,8 @@
>> #define STRINGIFY(x) #x
>> #define TOSTRING(x) STRINGIFY(x)
>>
>> +#define inline inline __attribute__((always_inline))
>> +
>
> I think redefining C keywords is generally a bad idea.
> Can you instead define an "always_inline" macro and
> use it where necessary?
In fact, commit b11d029b is an instance where compilation failed weirdly
because we redefined inline. I agree that a separate macro name, added
on where desired, rather than redefining 'inline' itself, is desirable.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-08 18:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 11:54 [Qemu-devel] [PATCH 1/9] tests: cris: force inlining Rabin Vincent
2016-09-05 11:54 ` [Qemu-devel] [PATCH 2/9] tests: cris: fix syscall inline asm Rabin Vincent
2016-09-05 18:20 ` Richard Henderson
2016-09-08 11:38 ` [Qemu-devel] [PATCHv2 2/8] " Rabin Vincent
2016-09-08 16:10 ` Richard Henderson
2016-09-05 11:54 ` [Qemu-devel] [PATCH 3/9] tests: cris: remove openpf4 test Rabin Vincent
2016-09-12 22:51 ` Edgar E. Iglesias
2016-09-05 11:54 ` [Qemu-devel] [PATCH 4/9] tests: cris: remove check_time1 Rabin Vincent
2016-09-12 23:00 ` Edgar E. Iglesias
2016-09-05 11:54 ` [Qemu-devel] [PATCH 5/9] target-cris: sync CC state at load/stores Rabin Vincent
2016-09-05 19:02 ` Richard Henderson
2016-09-06 21:52 ` Edgar E. Iglesias
2016-09-05 11:54 ` [Qemu-devel] [PATCH 6/9] target-cris: reduce v32isms from v10 log dumps Rabin Vincent
2016-09-12 22:59 ` Edgar E. Iglesias
2016-09-14 12:48 ` Hans-Peter Nilsson
2016-09-26 7:06 ` Rabin Vincent
2016-09-05 11:54 ` [Qemu-devel] [PATCH 7/9] target-cris: ignore prefix insns in singlestep Rabin Vincent
2016-09-12 22:49 ` Edgar E. Iglesias
2016-09-14 13:32 ` Hans-Peter Nilsson
2016-09-05 11:54 ` [Qemu-devel] [PATCH 8/9] target-cris: add v17 CPU Rabin Vincent
2016-09-12 22:18 ` Edgar E. Iglesias
2016-09-26 7:17 ` Rabin Vincent
2016-09-28 10:42 ` Edgar E. Iglesias
2016-09-30 16:50 ` Rabin Vincent
2016-09-05 11:54 ` [Qemu-devel] [PATCH 9/9] tests: cris: add v17 ADDC test Rabin Vincent
2016-09-12 23:16 ` Edgar E. Iglesias
2016-09-06 21:53 ` [Qemu-devel] [PATCH 1/9] tests: cris: force inlining Edgar E. Iglesias
2016-09-08 11:41 ` Rabin Vincent
2016-09-08 18:06 ` Peter Maydell
2016-09-08 18:21 ` Eric Blake [this message]
2016-09-12 9:43 ` [Qemu-devel] [PATCHv2 1/8] " Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a42bad3b-aeaa-2aa7-5f4e-624103a293e2@redhat.com \
--to=eblake@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rabin.vincent@axis.com \
--cc=rabinv@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).